Skip to content

[Feature flag] Enable optimal test webhook queries feature

What

Remove the :integrations_test_webhook_optimizations feature flag.

Owners

  • Team: ~"group::ecosystem"
  • Most appropriate slack channel to reach out to: #g_create_ecosystem
  • Best individual to reach out to: @.luke

Expectations

The Grafana latency graphs for Projects::HooksController#test should improve.

What are we expecting to happen?

The test webhook payloads should contain the most recent records of their type, rather than the oldest.

The queries should perform better for projects with large amounts of these records.

What might happen if this goes wrong?

Data could fail to return.

The queries could be less performant.

What can we monitor to detect problems with this?

Beta groups/projects

If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.

  • .luke/public-tests project
  • gitlab-org/gitlab project

Roll Out Steps

  • Enable on staging (/chatops run feature set feature_name true --staging)
  • Test on staging
  • [-] Ensure that documentation has been updated
  • Enable on GitLab.com for individual groups/projects listed above and verify behaviour (/chatops run feature set --project=gitlab-org/gitlab feature_name true)
  • [-] Coordinate a time to enable the flag with the SRE oncall and release managers
    • In #production mention @sre-oncall and @release-managers. Once an SRE on call and Release Manager on call confirm, you can proceed with the rollout
  • [-] Announce on the issue an estimated time this will be enabled on GitLab.com
  • Enable on GitLab.com by running chatops command in #production (/chatops run feature set feature_name true)
  • [-] Cross post chatops Slack command to #support_gitlab-com (more guidance when this is necessary in the dev docs) and in your team channel
  • Announce on the issue that the flag has been enabled
  • Remove feature flag and add changelog entry
  • After the flag removal is deployed, clean up the feature flag by running chatops command in #production channel

Rollback Steps

  • This feature can be disabled by running the following Chatops command:
/chatops run feature set integrations_test_webhook_optimizations false
Edited by Luke Duncalfe