Refactor: Migrate commit page mini pipeline to vue
Background
The commit page displays a mini-pipeline graph that has the same a appearance and functionality as the one in the pipelines list:
pipelines page (Vue) | commit page (HAML + jQuery) |
---|---|
Description
However, they are not implemented in the same way, in the case of the pipeline list page, the mini graph user Vue while in the commit page it uses jQuery and HAML.
The commit page mini pipeline to use the Vue. These are the entry points:
- https://gitlab.com/gitlab-org/gitlab/blob/c775596c644effaf7394679c31c4fece8f78a490/app/views/projects/commit/_commit_box.html.haml#L89
- https://gitlab.com/gitlab-org/gitlab/blob/c775596c644effaf7394679c31c4fece8f78a490/app/assets/javascripts/projects/commit_box/info/index.js#L16
Technical Details
- The Vue mini pipeline uses
app/assets/javascripts/pipelines/components/pipelines_list/stage.vue
to build a pipeline. Each of these stages create a mini pipeline. As a possible way to reorganize mini pipeline, as wrapper could be created to contain them. - The test class
js-builds-dropdown-button
should be removed in favor of adata-testid
selector.
Edited by Miguel Rincon