The docs review app environments are not being cleaned up
Update:
The docs review apps are now automatically being closed, but not deleted automatically, so they are still building up in the deleted tab. We need to clean this up, as they are useless refs
that could have performance implications for a few specific Git commands. See #296625 (closed)
Previous details:
It seems that the review-docs-cleanup
, that we in the Docs team thought was run and cleaned up on merge, was in fact skipped because it was in the wrong stage:
When you have an environment that has a stop action defined (typically when the environment describes a Review App), GitLab will automatically trigger a stop action when the associated branch is deleted. The stop_review job must be in the same stage as the deploy_review job in order for the environment to automatically stop.
This caused thousands of review-docs environments to be left stagnating in the project:
These should be cleaned up somehow, and the review app set to auto close when the branch in merged (I'll try to do that now).