Backups to Aliyun OSS fails to work with an internal VPC endpoint
Summary
A starter customer (internal link) reports that the currently included fog-aliyun
library version (0.3.3
), used in uploading backups to Alibaba Cloud's Object Storage Service does not work when using their internal VPC endpoint addresses.
The issue they face is also reported here: https://github.com/fog/fog-aliyun/issues/30
But it is reportedly already been addressed in more recent released versions (0.3.16
or higher) perhaps via https://github.com/fog/fog-aliyun/commit/ae204c0408ee6c98c95d433ea12dece3c17d31b0 and subsequent changes which switched the internal parts of fog-aliyun
to depend and utilize Aliyun's Ruby SDK library https://github.com/aliyun/aliyun-oss-ruby-sdk as its driving client.
Steps to reproduce
I lack access/credentials to Alibaba cloud services to reproduce this.
Customer reports this as immediately visible when performing a large backup file upload after configuring its internal VPC endpoint address.
While most of the codebase supports the OSS service through use of S3 compatible interfaces, backup has carried fog-aliyun
library as its supported method for the provider: gitlab-foss!11849 (merged)
Example Project
None, issue is specific to self-managed instances.
What is the current bug behavior?
Backup uploads to Aliyun OSS fails because it tries to reach an external address despite providing an internal VPC endpoint address.
What is the expected correct behavior?
Backup uploads to Aliyun OSS must work in both endpoint modes (public and internal VPC).
Relevant logs and/or screenshots
Likely the stacktrace visible here: https://github.com/fog/fog-aliyun/issues/44
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
Any recent GitLab version (reported over v13.5.1-ee)
Results of GitLab application Check
Expand for output related to the GitLab application check
Any recent GitLab version (reported over v13.5.1-ee)
Possible fixes
Upgrade dependency of fog-aliyun
to a recent release such as 0.3.19
: https://rubygems.org/gems/fog-aliyun/versions/0.1.0