Fix cop remaining cop offenses for Style/HashTransformation
Problem
In !55110 (merged) and https://gitlab.com/gitlab-org/gitlab-styles/-/merge_requests/75 we've introduced a new Style/HashTransformation
.
This MR enabled the
Proposed solution
Resolve auto-correctable file by letting RuboCop auto-correct them automatically
- Pick a file from The List below e.g.
app/controllers/projects/branches_controller.rb
- Create a branch (e.g.
pl-rubocop-style-hashtransformation-1
) - Delete the file from
.rubocop_manual_todo.yml
- Let RuboCop auto-correct the offenses via e.g.
bundle exec rubocop --auto-correct --only Style/HashTransformation app/controllers/projects/branches_controller.rb
- Check changes files and adjust if needed
- Commit and create a merge request adding
Contributes to #322739
and static code analysis label - Tick off the checkbox(es) and add the MR or mention this merge request in this issue
🎉
The List
-
app/controllers/projects/branches_controller.rb
- !56579 (merged) -
app/finders/ci/commit_statuses_finder.rb
- !56579 (merged) -
app/helpers/learn_gitlab_helper.rb
- !56579 (merged) -
app/models/ci/build_trace_chunk.rb
- !56579 (merged) -
app/models/concerns/cache_markdown_field.rb
- !56579 (merged) -
app/models/gpg_key.rb
- !56579 (merged) -
app/presenters/packages/npm/package_presenter.rb
- !56579 (merged) -
app/services/ci/pipeline_processing/atomic_processing_service/status_collection.rb
- !56579 (merged) -
app/services/ci/retry_build_service.rb
- !56579 (merged) -
app/services/packages/nuget/create_dependency_service.rb
- !56579 (merged) -
ee/app/models/ee/ci/build.rb
- !56581 (merged) -
ee/app/models/productivity_analytics.rb
- !56581 (merged) -
ee/app/models/sca/license_compliance.rb
- !56581 (merged) -
ee/app/services/security/store_report_service.rb
- !56581 (merged) -
ee/lib/ee/gitlab/auth/ldap/sync/group.rb
- !56581 (merged) -
ee/lib/ee/gitlab/usage_data.rb
- !56581 (merged) -
ee/lib/gitlab/custom_file_templates.rb
- !56581 (merged) -
ee/spec/elastic_integration/global_search_spec.rb
- !56581 (merged) -
ee/spec/lib/ee/gitlab/application_context_spec.rb
- !56581 (merged) -
lib/api/helpers/packages/conan/api_helpers.rb
- !56583 (merged) -
lib/api/projects.rb
- !56583 (merged) -
lib/atlassian/jira_connect/client.rb
- !56583 (merged) -
lib/banzai/filter/repository_link_filter.rb
- !56583 (merged) -
lib/gitlab/ci/config/entry/product/variables.rb
- !56583 (merged) -
lib/gitlab/ci/config/entry/variables.rb
- !56583 (merged) -
lib/gitlab/ci/variables/collection.rb
- !56583 (merged) -
lib/gitlab/ci/variables/helpers.rb
- !56583 (merged) -
lib/gitlab/git/commit.rb
- !56583 (merged) -
lib/gitlab/import_sources.rb
- !56583 (merged) -
lib/gitlab/language_detection.rb
- !56583 (merged) -
lib/gitlab/metrics/samplers/database_sampler.rb
- !56583 (merged) -
lib/gitlab/metrics/subscribers/active_record.rb
- !56583 (merged) -
lib/gitlab/phabricator_import/project_creator.rb
- !56583 (merged) -
lib/gitlab/prometheus_client.rb
- !56583 (merged) -
lib/gitlab/repository_hash_cache.rb
- !56583 (merged) -
lib/gitlab/static_site_editor/config/file_config.rb
- !56583 (merged) -
lib/gitlab/template/base_template.rb
- !56583 (merged) -
lib/gitlab/usage_data_counters/base_counter.rb
- !56583 (merged) -
lib/gitlab/usage_data_counters/note_counter.rb
- !56583 (merged) -
spec/lib/atlassian/jira_connect/serializers/pull_request_entity_spec.rb
- !56586 (merged) -
spec/lib/gitlab/ci/status/composite_spec.rb
- !56586 (merged) -
spec/lib/gitlab/conflict/file_spec.rb
- !56586 (merged) -
spec/lib/gitlab/import_export/project/tree_restorer_spec.rb
- !56586 (merged) -
spec/models/concerns/featurable_spec.rb
- !56586 (merged) -
spec/models/event_spec.rb
- !56586 (merged) -
spec/models/packages/dependency_spec.rb
- !56586 (merged) -
spec/requests/api/graphql/project/alert_management/alert/assignees_spec.rb
- !56586 (merged) -
spec/requests/api/graphql/project/alert_management/alert/notes_spec.rb
- !56586 (merged) -
spec/requests/api/graphql/project/alert_management/alert/todos_spec.rb
- !56586 (merged) -
spec/requests/api/projects_spec.rb
- !56586 (merged) -
spec/support/helpers/graphql_helpers.rb
- !56586 (merged) -
spec/support/import_export/project_tree_expectations.rb
- !56586 (merged) -
spec/support/shared_contexts/services/projects/container_repository/delete_tags_service_shared_context.rb
- !56586 (merged)
Edited by Peter Leitzen