Skip to content

Policy editor yaml mode UI is not synchronized properly

Summary

When editing security policies on the Security & Compliance -> Threat Monitoring -> Policies tab, when in yaml mode, the policy name, description, and enabled/disabled status are not synchronized with the yaml.

Steps to reproduce

For a walkthrough of the problem, please reference this very short video.

Example Project

https://gitlab.com/gitlab-org/threat-management/defend/demos/network-policy-demo/-/threat_monitoring/policies/new

What is the current bug behavior?

When users type in the name or description fields, or toggle the enabled/disabled status, it does not update the yaml to match.

What is the expected correct behavior?

The input areas at the top should always match the yaml shown down below.

Relevant logs and/or screenshots

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check 
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)


(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)


(we will only investigate if the tests are passing)

Proposal

Please see attached designs

Implementation plan

Edited by Alexander Turinske