Link to breadcrumbs on specific runners page is confusing.
Summary
On the page of a specific runner, the breadcrumbs shows something like $org > $project > Runners. When we click the Runners on breadcrumbs, it directs to nowhere but the same page.
Steps to reproduce
From sidebar, go into Settings > CI/CD > Runners > Specific Runners and click on any specific runner. It shows a breadcrumbs like $org > $project > Runners and the details of the specific runner.
Example Project
N/A. I don't know how to share the specific runners settings with you.
What is the current bug behavior?
The text shows Runners but the link goes to the specific runner page.
What is the expected correct behavior?
I think there's two options, and I prefer the first one.
- The text shows
Runners, and the link goes to the list of runners page. - The text shows
Runner #ID, and the link goes to the specific runner page (the same page).
Relevant logs and/or screenshots
Click on the Runners on breadcrumbs
Output of checks
This bug happens on GitLab.com
Possible fixes
I think it's here but I don't know how to fix it for now.
diff --git a/app/views/admin/runners/show.html.haml b/app/views/admin/runners/show.html.haml
index 6d8fad0eb8d..14facedeaa9 100644
--- a/app/views/admin/runners/show.html.haml
+++ b/app/views/admin/runners/show.html.haml
@@ -9,6 +9,10 @@
%span.runner-state.runner-state-specific
Specific
+- add_to_breadcrumbs _("Runners"), admin_runners_path
+- breadcrumb_title "##{@runner.id}"
+- @no_container = true
+
- if @runner.shared?
.bs-callout.bs-callout-success
%h4 This Runner will process jobs from ALL UNASSIGNED projects