Follow-up: Update the nMembers translation string in the approval modal
The following discussion from !56230 (merged) should be addressed:
-
!56230 (comment 528257073) - @rob.hunt I just have one concern over how we're breaking up one of the translated strings, but it otherwise looks like a great clean-up 👍
As it was originally there, I'm not going to block the MR, but I do wonder if we can move the nMembers
fully into the string? Something like
n__(
'ApprovalRuleRemove|You are about to remove the %{name} approver group which has %{strongStart}%d member%{strongEnd}.',
'ApprovalRuleRemove|You are about to remove the %{name} approver group which has %{strongStart}%d members%{strongEnd}.',
this.rule.approvers.length
)
Edited by Jiaan Louw