Rename DAST mount helpers to align with the rest of the codebase
In DAST, we have been naming mount helpers in Jest specs slightly differently than in the rest of the codebase. This boils down to subsequent review discussions (1, 2) where we meant to improve the naming of the entities under test.
In retrospect, those changes now feel like inconsistencies in the codebase because they have never propagated more widely in the codebase.
Since the most commonly used naming is wrapper
, let's refactor DAST specs to drop subject
in favor of wrapper
again. If we ever want to change this naming again the future, having all specs use the same names will make our lives easier for refactoring.
-
ee/spec/frontend/on_demand_scans/components/on_demand_scans_form_spec.js
-
Rename subject
towrapper
. -
Rename subjectMounterFactory
tocreateComponentFactory
. -
Rename mountSubject
tocreateComponent
. -
Rename mountShallowSubject
tocreateShallowComponent
.
-
Follows-up on !57584 (diffs, comment 539107434).
Edited by Paul Gascou-Vaillancourt