Skip to content

Removing the outdated method "Ci::ProcessPipelineService#update_retried"

Method => https://gitlab.com/gitlab-org/gitlab/-/blob/1c8e860ea3434e858f89dcebde0ed1c170c767b6/app/services/ci/process_pipeline_service.rb#L27-54

  • Firstly, I created an MR to remove the method directly: !50465 (closed).
  • In the MR, we decided to add a metric to see if this method is really used.
  • After adding the metric (!52331 (merged)), we saw that this method is still used.
  • We fixed the places that cause this method to be used: !54300 (merged).

We have 2 feature flags =>

  • ci_fix_commit_status_retried #321631 (closed) => This enables to assign "retried" for older commit statuses in some cases.
  • ci_remove_update_retried_from_process_pipeline #321630 (closed) => This disables the usage of #update_retried method.