Skip to content

Update controls in Admin -> Projects or Groups -> Access requests

Background

In Admin -> Projects -> Choose a project and Admin -> Groups -> Choose a group there is a Users requesting access to <group/project name> section that lists out access requests.

Screen_Shot_2021-04-09_at_11.06.19_AM

This is the last section that uses HAML controls https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/views/shared/members/_member.html.haml#L63 so it would be nice to be able to remove this HAML and subsequent legacy jQuery and CSS. Furthermore the role dropdown and datepicker don't actually work. It appears they haven't worked for a long time. I went back to a commit over a year ago and it was still broken. My guess is it was accidentally broken when refactoring to page specific JavaScript at some point. I couldn't find an open issue for this bug which makes me think not many people use these controls.

Implementation plan

Remove the controls and add Manage access button that links to the Access requests tab on the group members view.

Screen_Shot_2021-04-09_at_11.49.12_AM

  1. Finish &5616
  2. Add a tab= query string that allows deep linking into specific tabs
  3. Add show_controls: false parameter to app/views/shared/members/_requests.html.haml#L15 and add Manage access button to the header of that card
  4. In a follow-up MR remove all HAML below https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/views/shared/members/_member.html.haml#L65 as this is the last place that uses it.
Edited by Peter Hegman