Skip to content

[FE] Generic Report Schema: Render 'module-location' type on vulnerability details page

Why are we doing this work

Allows scan results to add new labels and values to a vulnerability, where the label is any string they want and the value is one of the following types: named-list, list, table, url, int, text, diff, markdown (GFM), code, commit, file-location, and module-location.

This issue is specific to the module-location type

Designs

component design
module-location Screen_Shot_2021-04-21_at_4.20.02_pm

Sample Data

Schema: https://gitlab.com/gitlab-org/security-products/security-report-schemas/-/blob/master/src/vulnerability-details-format.json

module-location (based on https://gitlab.com/gitlab-org/security-products/security-report-schemas/-/blob/master/src/vulnerability-details-format.json#L270)

{
"stack_trace": {
  "name": [ { "lang": "en", "value": "Stack Trace" } ],
  "type": "list",
  "items": [
    { "type": "module-location", "module_name": "compiled_binary", "offset": 100 },
    { "type": "module-location", "module_name": "compiled_binary", "offset": 500 },
    { "type": "module-location", "module_name": "compiled_binary", "offset": 700 },
    { "type": "module-location", "module_name": "compiled_binary", "offset": 1000 }
  ]
}}

Relevant links

Information that the developer might need to refer to when implementing the issue.

Non-functional requirements

  • Documentation:
  • Feature flag:
  • Performance:
  • Testing:

Implementation plan

  • frontend Add module-location component (it should render ${module_name}:${offset)
  • Add specs
Edited by -