Prevent creation of push_package event when package publication fails on package manager APIs
Background
During the review of !55018 (merged), it was discovered that the push_package
tracking event is created before the package, which can cause the event to be created even when the package file creation fails. For gitlab.com, the impact would be inaccurate push_package
counts in Package GitLab.com Stage Activity Dashboard (internal) and other Sisense dashboards used for product insights.
-
@10io started a discussion: (+3 comments)
Can we push this line on L189, right before
created!
.As it stands here, this will create an event even before we create the package = we're taking into account failed uploads.
Those events are used to build SiSense dashboards that will provide us insights such as which registries are the most used ones.
Goal
Check the publish API endpoints for each package format and make sure the push_package
is always created after the package and package file.
Package format | API endpoints file | MR |
---|---|---|
lib/api/terraform/modules/v1/packages.rb |
!55018 (merged) | |
|
lib/api/npm_project_packages.rb |
!68054 (merged) |
|
lib/api/maven_packages.rb |
!71618 (merged) |
|
lib/api/composer_packages.rb |
!72192 (merged) |