Cleanup timeout warning icon not displayed on the image repository list
Summary
In #276900 (closed), we decided to display the expiration_policy_cleanup_status
for container images.
I'm afraid we forgot about the page listing the container images.
Here is an example:
- All the container images have the yellow warning icon
- All the container images have the "Cleanup timeout..." explanation
but this is not correct because, if I check the cleanup status using the GraphQL API:
All container images are scheduled
and not unfinished
.
Example Project
https://gitlab.com/gitlab-org/security-products/analyzers/container-scanning/container_registry
What is the current bug behavior?
The icon on the container images list page for cleanup policies is not correct.
What is the expected correct behavior?
The icon on the container images list page for cleanup policies should reflect the cleanup status
Possible fixes
We could take this opportunity to throw there (the container images list page) all the statuses relevant for cleanups:
-
cleanup_unscheduled
: No icon / No explanation -
cleanup_scheduled
: An hourglass? /Cleanup will run soon
-
cleanup_ongoing
: A "play" icon /Cleanup is ongoing
-
cleanup_unfinished
: A warning icon /Cleanup timeout ...
(current explanation we have)
Proposal
In order to best articulate the cleanup status of individual image repositories inside the main container registry page, we will add a cleanup status metadata under the tag name. See the rough example below. The content and copy should be identical to previous clean-up policy statuses for consistency.
Rough concept |
---|