Follow-up from "Add CI/CD access token section in project settings"
The following discussion from !61935 (merged) should be addressed:
-
@cngo started a discussion: const findAddProjectBtn = () => wrapper.findByRole('button', { name: TokenAccess.i18n.addProject }); const findRemoveProjectBtn = () => wrapper.findByRole('button', { name: 'Remove access' });
Non-blocking: WDYT about using
findByRole
(from Testing Library) here instead? For it to work, we can doimport { mountExtended as mount } from 'helpers/vue_test_utils_helper';
. Then we can delete thedata-testid
s from the markup.The benefits are:
- We test closer to how the user uses the product, which is that they find elements by reading text labels etc. This is also what we recommend in our docs
- We remove
data-testid
s which stay in the production bundle, which would increase client bundle size