Inconsistent group list while importing projects using GitLab export and BitBucket cloud
Summary
If a user has developer or maintainer level permissions on a group and they try to import a project using BitBucket cloud
, the import page won't list the groups where the user has maintainer or developer permissions even if those roles are allowed to create new projects there. I think this is due to this check: https://gitlab.com/gitlab-org/gitlab/-/blob/v14.0.1-ee/app/services/import/base_service.rb#L16
But, if the user enters the target group and try to import a group using GitLab export
option, the current group is listed. BitBucket cloud
importer will not list this group still.
So, I feel this behaviour should be consistent across all the importers.
Steps to reproduce
- Create a user and link it with a Bitbucket cloud account.
- Grant this user developer permissions on a group.
- Make sure the setting
Allowed to create projects
for the group is set toDevelopers + Maintainers
. - Enter this group as the above user.
- Try to create a new project and import using
GitLab export
. This will list the group namespace correctly. - Now, re-enter the group and try to import a project using
BitBucket cloud
importer, it will only show the user namespace.- Had the user been an owner of the group/namespace, it should have been listed properly.
What is the current bug behavior?
Group list should be consistent for various importers.
What is the expected correct behavior?
Group list is not consistent across various importers.
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Ubuntu 18.04 Proxy: no Current User: git Using RVM: no Ruby Version: 2.7.2p137 Gem Version: 3.1.4 Bundler Version:2.1.4 Rake Version: 13.0.3 Redis Version: 6.0.14 Git Version: 2.32.0 Sidekiq Version:5.2.9 Go Version: unknown GitLab information Version: 14.0.3-ee Revision: b6033e36824 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 12.6 URL: https://ps-gitlab.sr.gitlab.support HTTP Clone URL: https://ps-gitlab.sr.gitlab.support/some-group/some-project.git SSH Clone URL: git@ps-gitlab.sr.gitlab.support:some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: no Using Omniauth: yes Omniauth Providers: openid_connect, bitbucket GitLab Shell Version: 13.19.0 Repository storage paths: - default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
[WARNING] Object storage for pages must have a bucket specified Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 13.19.0 ? ... OK (13.19.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Internal API available: OK Redis available via internal API: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes (cluster/worker) ... 1/1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 1/2 ... yes 1/3 ... yes 6/4 ... yes 5/5 ... yes 1/6 ... yes 1/7 ... yes 1/8 ... yes 1/9 ... yes 1/10 ... yes 1/11 ... yes 1/12 ... yes 1/13 ... yes 1/14 ... yes 1/15 ... yes 1/16 ... yes 11/17 ... yes 1/18 ... yes 10/19 ... yes 2/20 ... yes 1/22 ... yes 2/23 ... yes 11/24 ... yes 10/25 ... yes 1/26 ... yes 1/27 ... yes 1/29 ... yes 1/30 ... yes 1/31 ... yes 1/32 ... yes 1/33 ... yes 1/34 ... yes Redis version >= 5.0.0? ... yes Ruby version >= 2.7.2 ? ... yes (2.7.2) Git version >= 2.31.0 ? ... yes (2.32.0) Git user has default SSH configuration? ... yes Active users: ... 6 Is authorized keys file accessible? ... yes GitLab configured to store new projects in hashed storage? ... yes All projects are in hashed storage? ... yes Elasticsearch version 7.x (6.4 - 6.x deprecated to be removed in 13.8)? ... skipped (elasticsearch is disabled)
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished