Vulnerability Details: Create new Jira-issue shows even when its not enabled
Summary
NOTE: This bug is currently behind a default-disabled feature flag.
On the vulnerability details page it shows a Create Jira Issue
button even when the jira issue integration is not enabled.
Steps to reproduce
- Enable the
create_vulnerability_jira_issue_via_graphql
feature flag - Make sure Project > Integration Settings > Jira > "Enable Jira Issues" or "Enable Jira issues creation from vulnerabilities` is disabled
- Browse to a vulnerability's details page
What is the current bug behavior?
with "Enable Jira issues creation from vulnerabilities" disabled | with "Enable Jira issues" disabled |
---|---|
What is the expected correct behavior?
expected in both cases |
---|
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
Quick fix: We need to add an additional check to make sure that the createJiraIssueUrl
is set within ee/app/assets/javascripts/vulnerabilities/components/footer.vue
Long-term fix: Since we are trying to move away from the url-based approach we need to pass a boolean value to the frontend to indicate that the jira-integration for issues has been enabled.