Marking an MR as "Ready" shows Banner with "can now be merged" even if approvals or merge checks are missing
Summary
When clicking the MR button "Mark as ready", always a message banner shows up with the text "The merge request can now be merged.", even when approvals or merge checks are still missing and the MR can in fact NOT yet be merged. The message is confusing.
Original bug report
Steps to reproduce
- Create a Draft MR in a repo that has required approvers and successful pipelines set up as merge requirement
- Click the "Mark as ready" button in the MR
What is the current bug behavior?
The banner shows up which is confusing.
What is the expected correct behavior?
The banner could just be removed imho since it does not provide helpful information.
Relevant logs and/or screenshots
Proposal
- Update wording of alert to
Marked as ready. Merging is now allowed.
Edited by Annabel Dunstone Gray