Follow-up from "Fix style and language issues in Elasticsearch page"
The following discussions from !69743 (merged) should be addressed:
-
@aqualls started a discussion: I'd like you to take another try at these lines. Can we get rid of the bolding, and the
This is
? I suspect the last two sentences can be combined and rewritten for clarity. -
@aqualls started a discussion: Consider:
The search index updates after you: - Add data to the database or repository. - [Enable Elasticsearch](#enable-advanced-search) in the Admin Area.
This sentence stood out because of the passive voice:
is added
,is enabled
,is updated
. When you see lots ofis
is
is
, look for a way to rewrite it in active voice. -
@aqualls started a discussion: Active voice can help here:
This document describes how to enable Advanced Search. When enabled, Advanced Search provides you: - Faster search response times. - Improved [search features](../user/search/advanced_search.md).
(
is enabled
,you'll have
etc) -
@aqualls started a discussion: (+1 comment) @fneill I'm partway through the document, and I think I need to pause to ask some questions about your intent before I proceed. I may be attempting a harder edit than you truly needed or wanted. Are you attempting a full cleanup, or just workflow practice? I ask because there are 100+ Vale suggestions for this page. They're relatively easy to implement, BUT if you're looking to practice process, I should stop my edits here.
If what you intend is to get MR practice, then I do not want to punish you by adding in a full edit. Instead, let's keep your work (and my edits!) an MVC, and get it out the door:
- You can choose to take or leave the first suggestions I've made
- Practice using the thread I'm making right here, to create a new follow-up issue for you
- Ask @kpaizee to approve / merge this MR during your working hours so you can keep going
- Make another round of revisions in a follow-up MR, and send it my way. I'm 100% on board with the idea of doing multiple MVCs on a change so you can get used to the manner of working merge requests, and I'm happy to look at those overnight for you.
Lastly - I'm pretty sure this was more than a tw-weight1 of effort. This feels more like a tw-weight5 given the changes span multiple subheadings on a single page AND correct a few inbound links.