Remove orphaned RuboCop excludes from .rubocop_todo/**/*.yml
Problem
We are doing a great job removing remaining RuboCop offenses listed in .rubocop_todo/**/*.yml
Sometimes, however, we forget to remove the fixed file from the Exclude
list after a particular offenses has been fixed.
Moreover, if a file is moved or removed, sometimes, it won't be removed from the Exclude
list. They become orphaned entries.
Those orphaned Exclude
s entries allow offenses to sneak back in again (if REVEAL_RUBOCOP_TODO=0
which is the default).
Note, !72791 (merged) moved todos from .rubocop_manual_todo.yml
to .rubocop_todo/**/*.yml
.
Proposed solution
With Split up .rubocop_todo.yml into .rubocop_todo/*... (#354328 - closed) completed we can use rake rubocop:todo:generate
or rake rubocop:todo:generate[<COP NAME>]
(see docs) to regenerate TODO lists which also removes superfluous excludes.
This script below
Remove missing and superfluous excludes from .rubocop_todo/**/*.yml
](https://gitlab.com/gitlab-org/gitlab/-/tree/master/.rubocop_todo) by running the script which prints all orphaned Exclude
s.
Automation?
Later, we could use a modified version of the script to be run in CI checking for orphaned Exclude
s.
The script
# frozen_string_literal: true
require "bundler/setup"
require "rubocop"
require "stringio"
require "json"
def read_todos(excludes, root)
Dir[".rubocop_todo/**/*.yml"].each do |config|
yaml = YAML.load_file(config)
yaml.each do |cop_name, cop_config|
next unless cop_config.key?("Exclude")
excludes[cop_name] = cop_config["Exclude"]
.map { |path| normalize_path(root, path) }
.select(&method(:only_ruby_file))
.uniq
end
end
end
def only_ruby_file(path)
/\.rb$/.match?(path)
end
def normalize_path(root, path)
npath = File.expand_path(path, root)
npath.delete_prefix(root)
end
def catpure_stdout
original = $stdout
$stdout = StringIO.new
yield
$stdout.string
ensure
$stdout = original
end
def mark_non_existant(excludes, missing_excludes, missing_files)
excludes.each do |cop_name, existing_excludes|
missing_files.each do |missing_file|
missing_excludes[cop_name] << missing_file if existing_excludes.include?(missing_file)
end
end
end
def run_rubocop(cop_names, files)
ENV['REVEAL_RUBOCOP_TODO'] = '1'
cli = RuboCop::CLI.new
catpure_stdout do
cli.run([
"--format", "json",
"--parallel",
"--only", cop_names.join(","),
*files
])
end
end
def mark_superfluous(output, excludes, missing_files)
superfluous_excludes = excludes.dup
json = JSON(output)
json.fetch("files").each do |file|
path = file.fetch("path")
cop_names = file.fetch("offenses").map { |o| o["cop_name"] }.uniq
cop_names.each do |cop_name|
superfluous_excludes[cop_name]&.delete(path)
end
end
remove_missing(superfluous_excludes, missing_files)
end
def remove_missing(superfluous_excludes, missing_files)
superfluous_excludes.each do |cop_name, files|
files.delete_if { |file| missing_files.include? file }
end
end
def print_excludes_for(cop_name, missing, superfluous)
return if missing.empty? && superfluous.empty?
puts " - [ ] `#{cop_name}`:"
print_excludes("Missing excludes", missing) if missing.any?
print_excludes("Superfluous excludes", superfluous) if superfluous.any?
end
def print_excludes(title, files)
puts " - #{title}:"
files.each do |file|
puts " - `#{file}`"
end
end
def main
# cop_name => [list of excludes]
excludes = {}
# cop_name => [list of missing files]
missing_excludes = Hash.new { |hash, cop_name| hash[cop_name] = [] }
root = Dir.pwd << "/"
read_todos(excludes, root)
files, missing_files = excludes.values.flatten(1)
.map { |path| normalize_path(root, path) }.uniq
.partition(&File.method(:exist?))
cop_names = excludes.keys
mark_non_existant(excludes, missing_excludes, missing_files)
output = run_rubocop(cop_names, files)
superfluous_excludes = mark_superfluous(output, excludes, missing_files)
(missing_excludes.keys + superfluous_excludes.keys).uniq.sort.each do |cop_name|
print_excludes_for(cop_name, missing_excludes[cop_name], superfluous_excludes[cop_name])
end
end
main
Exclude
s
Cops with orphaned The list has become so large that we need a collapsible section here.
The orphaned cops list
-
Capybara/VisibilityMatcher
:- Superfluous excludes:
ee/spec/features/billings/billing_plans_spec.rb
spec/features/issues/filtered_search/dropdown_assignee_spec.rb
spec/features/issues/filtered_search/dropdown_author_spec.rb
spec/features/issues/filtered_search/dropdown_emoji_spec.rb
spec/features/issues/filtered_search/dropdown_hint_spec.rb
spec/features/issues/filtered_search/recent_searches_spec.rb
spec/features/issues/filtered_search/search_bar_spec.rb
spec/features/issues/filtered_search/visual_tokens_spec.rb
- Superfluous excludes:
-
Cop/UserAdmin
:- Missing excludes:
app/controllers/concerns/spammable_actions.rb
ee/app/graphql/mutations/admin/analytics/devops_adoption/segments/mixins.rb
ee/app/graphql/resolvers/admin/analytics/devops_adoption/segments_resolver.rb
lib/api/entities/ci/user_safe.rb
lib/gitlab/background_migration/user_mentions/models/group.rb
- Superfluous excludes:
app/helpers/nav_helper.rb
ee/app/models/protected_environment/deploy_access_level.rb
ee/app/policies/ee/project_policy.rb
lib/api/entities/ci/runner_details.rb
lib/gitlab/ci/runner_instructions.rb
qa/qa/runtime/api/client.rb
- Missing excludes:
-
Gitlab/FeatureAvailableUsage
:- Missing excludes:
ee/app/finders/ee/alert_management/alerts_finder.rb
ee/app/controllers/projects/cluster_agents_controller.rb
ee/app/controllers/projects/iterations/inherited_controller.rb
ee/app/finders/clusters/agents_finder.rb
ee/app/graphql/resolvers/clusters/agent_tokens_resolver.rb
ee/app/helpers/ee/clusters_helper.rb
ee/app/models/concerns/has_timelogs_report.rb
ee/app/models/namespace_statistics.rb
ee/app/policies/ee/namespace_policy.rb
ee/app/services/clusters/agent_tokens/create_service.rb
ee/app/services/clusters/agents/create_service.rb
ee/app/services/dast/profiles/create_service.rb
ee/app/services/dast/profiles/update_service.rb
ee/app/services/dast_on_demand_scans/create_service.rb
ee/app/services/dast_site_tokens/create_service.rb
ee/app/services/dast_site_validations/create_service.rb
ee/app/services/dast_site_validations/revoke_service.rb
ee/app/services/dast_site_validations/validate_service.rb
ee/lib/api/external_status_checks.rb
ee/lib/ee/api/job_artifacts.rb
- Superfluous excludes:
app/policies/project_policy.rb
ee/app/graphql/mutations/dast/profiles/create.rb
ee/app/graphql/mutations/dast/profiles/run.rb
ee/app/graphql/mutations/dast/profiles/update.rb
ee/app/services/ee/merge_requests/update_service.rb
ee/app/services/merge_requests/sync_report_approver_approval_rules.rb
ee/app/services/quality_management/test_cases/create_service.rb
ee/lib/ee/api/internal/kubernetes.rb
ee/lib/gitlab/incident_management.rb
- Missing excludes:
-
Gitlab/NamespacedClass
:- Missing excludes:
app/workers/project_daily_statistics_worker.rb
app/workers/repository_remove_remote_worker.rb
- Missing excludes:
-
GraphQL/OrderedArguments
:- Superfluous excludes:
app/graphql/resolvers/base_issues_resolver.rb
app/graphql/resolvers/design_management/designs_resolver.rb
app/graphql/resolvers/design_management/version/design_at_version_resolver.rb
- Superfluous excludes:
-
GraphQL/OrderedFields
:- Missing excludes:
ee/app/graphql/types/scan_execution_policy_type.rb
- Superfluous excludes:
app/graphql/types/ci/runner_platform_type.rb
app/graphql/types/ci/stage_type.rb
app/graphql/types/ci/status_action_type.rb
app/graphql/types/ci/template_type.rb
app/graphql/types/commit_type.rb
app/graphql/types/container_expiration_policy_type.rb
app/graphql/types/container_repository_tag_type.rb
app/graphql/types/dependency_proxy/blob_type.rb
app/graphql/types/dependency_proxy/image_ttl_group_policy_type.rb
app/graphql/types/design_management/design_collection_type.rb
app/graphql/types/diff_refs_type.rb
app/graphql/types/diff_stats_summary_type.rb
app/graphql/types/diff_stats_type.rb
app/graphql/types/error_tracking/sentry_detailed_error_type.rb
app/graphql/types/error_tracking/sentry_error_collection_type.rb
app/graphql/types/error_tracking/sentry_error_frequency_type.rb
app/graphql/types/error_tracking/sentry_error_stack_trace_context_type.rb
app/graphql/types/error_tracking/sentry_error_stack_trace_entry_type.rb
app/graphql/types/metadata/kas_type.rb
app/graphql/types/metadata_type.rb
app/graphql/types/namespace/package_settings_type.rb
app/graphql/types/namespace_type.rb
app/graphql/types/notes/diff_position_type.rb
app/graphql/types/notes/discussion_type.rb
app/graphql/types/notes/note_type.rb
app/graphql/types/packages/nuget/metadatum_type.rb
app/graphql/types/packages/package_dependency_link_type.rb
app/graphql/types/packages/package_file_type.rb
app/graphql/types/packages/package_tag_type.rb
app/graphql/types/packages/package_type.rb
app/graphql/types/project_type.rb
app/graphql/types/projects/services/jira_project_type.rb
app/graphql/types/release_asset_link_type.rb
app/graphql/types/release_links_type.rb
app/graphql/types/release_type.rb
app/graphql/types/repository_type.rb
app/graphql/types/task_completion_status.rb
app/graphql/types/tree/blob_type.rb
ee/app/graphql/types/epic_type.rb
ee/app/graphql/types/geo/geo_node_type.rb
ee/app/graphql/types/requirements_management/requirement_states_count_type.rb
ee/app/graphql/types/scanned_resource_type.rb
ee/app/graphql/types/security_report_summary_section_type.rb
ee/app/graphql/types/timebox_report_type.rb
- Missing excludes:
-
GraphQL/ResolverMethodLength
:- Superfluous excludes:
app/graphql/types/packages/package_type.rb
- Superfluous excludes:
-
Layout/ArgumentAlignment
:- Missing excludes:
lib/gitlab/diff/custom_diff.rb
spec/controllers/projects/serverless/functions_controller_spec.rb
lib/gitlab/background_migration/migrate_stage_status.rb
ee/app/graphql/ee/mutations/ci/ci_cd_settings_update.rb
ee/spec/graphql/mutations/incident_management/timeline_event/create_spec.rb
ee/spec/helpers/projects/security/policies_helper_spec.rb
spec/features/projects/serverless/functions_spec.rb
- Superfluous excludes:
app/controllers/projects_controller.rb
app/graphql/mutations/ci/ci_cd_settings_update.rb
app/models/concerns/issuable.rb
app/models/integrations/jira.rb
ee/app/graphql/resolvers/security_orchestration/scan_execution_policy_resolver.rb
ee/app/models/ee/lfs_object.rb
ee/app/models/ee/merge_request_diff.rb
ee/app/models/ee/pages_deployment.rb
ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb
lib/api/ci/job_artifacts.rb
lib/gitlab/ci/variables/builder.rb
qa/qa/page/base.rb
spec/features/projects/milestones/milestones_sorting_spec.rb
spec/lib/gitlab/database/partitioning_migration_helpers/index_helpers_spec.rb
spec/requests/lfs_http_spec.rb
- Missing excludes:
-
Layout/FirstArrayElementIndentation
:- Missing excludes:
ee/app/serializers/merge_request_compliance_entity.rb
lib/gitlab/integrations/sti_type.rb
spec/experiments/new_project_sast_enabled_experiment_spec.rb
- Superfluous excludes:
app/models/integrations/bamboo.rb
ee/spec/services/iterations/cadences/create_service_spec.rb
qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_instance_level_spec.rb
qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_project_level_spec.rb
spec/features/issues/filtered_search/filter_issues_spec.rb
spec/features/issues/filtered_search/visual_tokens_spec.rb
spec/lib/gitlab/ci/config/entry/root_spec.rb
spec/support/matchers/background_migrations_matchers.rb
- Missing excludes:
-
Layout/FirstHashElementIndentation
:- Missing excludes:
spec/lib/gitlab/hook_data/issuable_builder_spec.rb
ee/spec/helpers/projects/security/policies_helper_spec.rb
ee/app/helpers/ee/ide_helper.rb
ee/spec/helpers/projects/threat_monitoring_helper_spec.rb
spec/support/shared_examples/models/issuable_hook_data_shared_examples.rb
- Superfluous excludes:
app/controllers/projects/merge_requests_controller.rb
app/helpers/diff_helper.rb
ee/app/services/projects/slack_application_install_service.rb
ee/spec/elastic/migrate/20210421140400_add_new_data_to_merge_requests_documents_spec.rb
ee/spec/elastic/migrate/20210623081800_add_upvotes_to_issues_spec.rb
ee/spec/lib/ee/audit/project_changes_auditor_spec.rb
ee/spec/requests/api/graphql/merge_requests/approval_state_spec.rb
ee/spec/requests/api/graphql/mutations/issues/update_spec.rb
qa/qa/specs/features/browser_ui/3_create/web_ide/open_fork_in_web_ide_spec.rb
spec/controllers/projects/group_links_controller_spec.rb
spec/requests/api/graphql/project/terraform/state_spec.rb
spec/requests/api/graphql/project/terraform/states_spec.rb
- Missing excludes:
-
Layout/HashAlignment
:- Missing excludes:
ee/lib/gitlab/geo/replication/base_transfer.rb
spec/lib/gitlab/hook_data/issuable_builder_spec.rb
spec/services/ci/retry_build_service_spec.rb
- Superfluous excludes:
app/graphql/types/packages/package_type.rb
app/models/wiki.rb
ee/app/models/ci/minutes/usage.rb
ee/app/services/external_status_checks/create_service.rb
ee/lib/ee/audit/project_changes_auditor.rb
spec/controllers/projects/issues_controller_spec.rb
spec/features/groups/issues_spec.rb
spec/models/project_spec.rb
spec/requests/api/graphql/packages/conan_spec.rb
- Missing excludes:
-
Layout/LineLength
:- Missing excludes:
ee/lib/system_check/app/elasticsearch_check.rb
lib/gitlab/kubernetes/cilium_network_policy.rb
lib/gitlab/kubernetes/network_policy.rb
spec/lib/gitlab/kubernetes/network_policy_spec.rb
spec/controllers/projects/serverless/functions_controller_spec.rb
ee/lib/gitlab/geo/replication/base_transfer.rb
ee/spec/lib/gitlab/geo/replication/file_transfer_spec.rb
ee/spec/lib/gitlab/geo/replication/job_artifact_transfer_spec.rb
ee/spec/models/ci/minutes/quota_spec.rb
app/services/service_ping/devops_report_service.rb
ee/app/services/epic_links/create_service.rb
ee/spec/uploaders/every_gitlab_uploader_spec.rb
ee/spec/lib/gitlab/geo/log_cursor/events/job_artifact_deleted_event_spec.rb
ee/spec/lib/gitlab/geo/replication/job_artifact_downloader_spec.rb
ee/spec/workers/network_policy_metrics_worker_spec.rb
ee/app/models/incident_management/timeline_event.rb
app/models/concerns/sha256_attribute.rb
app/workers/quality/test_data_cleanup_worker.rb
db/migrate/20220221102333_change_maintenance_note_limit_in_ci_runner.rb db/migrate/20220221102333_change_maintainer_note_limit_in_ci_runner.rb
ee/app/controllers/projects/threat_monitoring_controller.rb
ee/app/helpers/projects/security/policies_helper.rb
ee/app/services/alert_management/metric_images/upload_service.rb
ee/app/services/epic_links/list_service.rb
ee/lib/api/alert_management_alerts.rb
ee/lib/gitlab/geo/replication/base_downloader.rb
ee/spec/controllers/groups/epic_links_controller_spec.rb
ee/spec/controllers/projects/threat_monitoring_controller_spec.rb
ee/spec/features/admin/licenses/admin_uploads_license_spec.rb
ee/spec/finders/geo/job_artifact_legacy_registry_finder_spec.rb
ee/spec/finders/incident_management/timeline_events_finder_spec.rb
ee/spec/graphql/mutations/incident_management/timeline_event/update_spec.rb
ee/spec/graphql/resolvers/incident_management/timeline_events_resolver_spec.rb
ee/spec/lib/gitlab/geo/replication/file_retriever_spec.rb
ee/spec/lib/gitlab/geo/replication/job_artifact_retriever_spec.rb
ee/spec/lib/system_check/app/elasticsearch_check_spec.rb
ee/spec/models/incident_management/timeline_event_spec.rb
ee/spec/requests/api/alert_management_alerts_spec.rb
ee/spec/requests/api/graphql/mutations/incident_management/timeline_event/update_spec.rb
ee/spec/requests/api/graphql/project/incident_management/timeline_events_spec.rb
ee/spec/serializers/merge_request_compliance_entity_spec.rb
ee/spec/services/alert_management/metric_images/upload_service_spec.rb
ee/spec/services/ee/service_ping/service_ping_settings_spec.rb
ee/spec/services/epic_links/create_service_spec.rb
ee/spec/services/system_notes/incidents_service_spec.rb
lib/atlassian/jira_connect/asymmetric_jwt.rb
qa/qa/service/cluster_provider/k3s_cilium.rb
qa/qa/specs/features/browser_ui/6_release/pipeline/multi-project_pipelines_spec.rb
qa/qa/specs/features/browser_ui/6_release/pipeline/parent_child_pipelines_dependent_relationship_spec.rb
qa/qa/specs/features/browser_ui/6_release/pipeline/parent_child_pipelines_independent_relationship_spec.rb
qa/qa/specs/features/ee/browser_ui/10_protect/policy_alerts_list_spec.rb
qa/qa/specs/features/ee/browser_ui/4_verify/cancelling_merge_request_in_merge_train_spec.rb
qa/spec/qa_deprecation_toolkit_env.rb
spec/controllers/admin/requests_profiles_controller_spec.rb
spec/finders/error_tracking/errors_finder_spec.rb
spec/lib/atlassian/jira_connect/asymmetric_jwt_spec.rb
spec/lib/backup/artifacts_spec.rb
spec/lib/backup/lfs_spec.rb
spec/lib/backup/object_backup_spec.rb
spec/lib/backup/pages_spec.rb
spec/lib/backup/uploads_spec.rb
spec/lib/gitlab/ci/templates/managed_cluster_applications_gitlab_ci_yaml_spec.rb
spec/lib/gitlab/kubernetes/cilium_network_policy_spec.rb
spec/migrations/backfill_work_item_type_id_on_issues_spec.rb
spec/rubocop/cop/qa/testcase_link_format_spec.rb
spec/services/authorized_project_update/project_create_service_spec.rb
spec/services/service_ping/service_ping_settings_spec.rb
- Superfluous excludes:
app/controllers/admin/runners_controller.rb
app/controllers/concerns/product_analytics_tracking.rb
app/controllers/groups/runners_controller.rb
app/controllers/import/fogbugz_controller.rb
app/controllers/jira_connect/application_controller.rb
app/controllers/projects/pipelines/tests_controller.rb
app/graphql/resolvers/ci/runner_status_resolver.rb
app/graphql/types/packages/package_type.rb
app/models/broadcast_message.rb
app/models/ci/secure_file.rb
app/models/concerns/limitable.rb
app/models/merge_request_reviewer.rb
app/presenters/pages_domain_presenter.rb
app/services/bulk_imports/file_decompression_service.rb
app/services/ci/queue/pending_builds_strategy.rb
app/services/groups/open_issues_count_service.rb
app/services/merge_requests/mergeability/run_checks_service.rb
app/services/service_ping/submit_service.rb
config/initializers/0_marginalia.rb
config/initializers/active_record_transaction_observer.rb
config/initializers/content_security_policy.rb
ee/app/controllers/ee/projects/pipelines_controller.rb
ee/app/controllers/ee/sessions_controller.rb
ee/app/controllers/groups/analytics/cycle_analytics_controller.rb
ee/app/controllers/groups/usage_quotas_controller.rb
ee/app/controllers/profiles/usage_quotas_controller.rb
ee/app/controllers/trial_registrations_controller.rb
ee/app/graphql/ee/mutations/issues/create.rb
ee/app/graphql/resolvers/network_policy_resolver.rb
ee/app/graphql/resolvers/vulnerability_severities_count_resolver.rb
ee/app/graphql/types/network_policy_type.rb
ee/app/helpers/ee/application_settings_helper.rb
ee/app/helpers/security_helper.rb
ee/app/mailers/ee/emails/projects.rb
ee/app/models/ee/member.rb
ee/app/services/ee/merge_requests/base_service.rb
ee/app/services/ee/notification_service.rb
ee/app/services/security/security_orchestration_policies/rule_schedule_service.rb
ee/elastic/migrate/20210302104500_migrate_notes_to_separate_index.rb
ee/elastic/migrate/20210421140400_add_new_data_to_merge_requests_documents.rb
ee/elastic/migrate/20210429154500_migrate_merge_requests_to_separate_index.rb
ee/elastic/migrate/20210510113500_delete_merge_requests_from_original_index.rb
ee/elastic/migrate/20210510143200_delete_notes_from_original_index.rb
ee/lib/api/managed_licenses.rb
ee/lib/ee/gitlab/background_migration/populate_namespace_statistics.rb
ee/lib/ee/gitlab/checks/diff_check.rb
ee/lib/elastic/latest/merge_request_class_proxy.rb
ee/lib/gitlab/analytics/cycle_analytics/summary/lead_time.rb
ee/spec/elastic/migrate/20210201104800_migrate_notes_to_separate_index_spec.rb
ee/spec/elastic/migrate/20210421140400_add_new_data_to_merge_requests_documents_spec.rb
ee/spec/elastic/migrate/20210429154500_migrate_merge_requests_to_separate_index_spec.rb
ee/spec/elastic/migrate/20210510113500_delete_merge_requests_from_original_index_spec.rb
ee/spec/elastic/migrate/20210510143200_delete_notes_from_original_index_spec.rb
ee/spec/factories/requirements_management/requirements.rb
ee/spec/features/ci_shared_runner_warnings_spec.rb
ee/spec/graphql/mutations/dast_scanner_profiles/delete_spec.rb
ee/spec/graphql/types/network_policy_type_spec.rb
ee/spec/helpers/ee/application_settings_helper_spec.rb
ee/spec/helpers/ee/registrations_helper_spec.rb
ee/spec/helpers/security_helper_spec.rb
ee/spec/lib/ee/api/entities/billable_member_spec.rb
ee/spec/lib/gitlab/elastic/client_spec.rb
ee/spec/lib/gitlab/geo/cron_manager_spec.rb
ee/spec/models/geo/job_artifact_registry_spec.rb
ee/spec/replicators/geo/upload_replicator_spec.rb
ee/spec/services/projects/group_links/create_service_spec.rb
ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities_spec.rb
ee/spec/services/vulnerabilities/destroy_dismissal_feedback_service_spec.rb
ee/spec/support/shared_examples/features/over_free_user_limit_shared_examples.rb
ee/spec/workers/analytics/cycle_analytics/incremental_worker_spec.rb
ee/spec/workers/security/create_orchestration_policy_worker_spec.rb
lib/api/group_container_repositories.rb
lib/api/helpers/internal_helpers.rb
lib/error_tracking/sentry_client/issue.rb
lib/gitlab/background_migration/copy_column_using_background_migration_job.rb
lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects.rb
lib/gitlab/database/load_balancing/configuration.rb
lib/gitlab/database/migrations/test_background_runner.rb
lib/gitlab/database/query_analyzers/restrict_allowed_schemas.rb
lib/gitlab/git_access_wiki.rb
lib/gitlab/metrics/rails_slis.rb
lib/sidebars/groups/menus/settings_menu.rb
lib/sidebars/projects/menus/infrastructure_menu.rb
qa/qa/resource/project.rb
qa/qa/runtime/browser.rb
qa/qa/scenario/template.rb
qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_file_size_spec.rb
qa/qa/specs/features/browser_ui/4_verify/pipeline/run_pipeline_with_manual_jobs_spec.rb
qa/qa/specs/features/ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb
qa/qa/specs/features/ee/browser_ui/2_plan/iterations/assign_group_iteration_spec.rb
qa/qa/specs/runner.rb
qa/spec/page/logging_spec.rb
qa/spec/scenario/template_spec.rb
qa/spec/spec_helper.rb
spec/commands/metrics_server/metrics_server_spec.rb
spec/controllers/groups/settings/ci_cd_controller_spec.rb
spec/features/issues/filtered_search/visual_tokens_spec.rb
spec/finders/keys_finder_spec.rb
spec/finders/packages/build_infos_finder_spec.rb
spec/graphql/mutations/security/ci_configuration/base_security_analyzer_spec.rb
spec/graphql/types/container_repository_details_type_spec.rb
spec/graphql/types/container_repository_type_spec.rb
spec/graphql/types/mutation_type_spec.rb
spec/lib/error_tracking/sentry_client/issue_spec.rb
spec/lib/gitlab/checks/changes_access_spec.rb
spec/lib/gitlab/database/load_balancing/setup_spec.rb
spec/migrations/20210918201050_remove_old_pending_jobs_for_recalculate_vulnerabilities_occurrences_uuid_spec.rb
spec/models/container_registry/event_spec.rb
spec/requests/api/graphql/project/project_members_spec.rb
spec/scripts/changed-feature-flags_spec.rb
spec/services/ci/retry_job_service_spec.rb
spec/services/customer_relations/contacts/update_service_spec.rb
spec/services/groups/open_issues_count_service_spec.rb
spec/services/projects/open_issues_count_service_spec.rb
spec/services/service_ping/submit_service_ping_service_spec.rb
spec/workers/clusters/applications/activate_service_worker_spec.rb
spec/workers/merge_requests/create_pipeline_worker_spec.rb
- Missing excludes:
-
Layout/MultilineOperationIndentation
:- Missing excludes:
rubocop/cop/migration/hash_index.rb
- Superfluous excludes:
app/helpers/application_settings_helper.rb
app/services/groups/group_links/create_service.rb
ee/lib/elastic/latest/issue_class_proxy.rb
- Missing excludes:
-
Layout/SpaceInLambdaLiteral
:- Missing excludes:
ee/app/serializers/merge_request_compliance_entity.rb
- Superfluous excludes:
app/graphql/types/permission_types/base_permission_type.rb
ee/lib/ee/api/entities/geo_node_status.rb
- Missing excludes:
-
Layout/SpaceInsideBlockBraces
:- Missing excludes:
ee/spec/uploaders/every_gitlab_uploader_spec.rb
spec/workers/repository_remove_remote_worker_spec.rb
- Superfluous excludes:
ee/spec/controllers/countries_controller_spec.rb
ee/spec/features/issues/filtered_search/filter_issues_by_iteration_spec.rb
ee/spec/helpers/ee/registrations_helper_spec.rb
ee/spec/models/approvals/scan_finding_wrapped_rule_set_spec.rb
ee/spec/requests/api/graphql/project/dast_site_validations_spec.rb
ee/spec/workers/security/create_orchestration_policy_worker_spec.rb
lib/gitlab/database/migrations/test_background_runner.rb
qa/qa/specs/features/browser_ui/1_manage/project/project_access_token_spec.rb
qa/spec/scenario/test/integration/mattermost_spec.rb
spec/controllers/groups/settings/ci_cd_controller_spec.rb
spec/lib/feature/definition_spec.rb
spec/lib/gitlab/database_spec.rb
spec/lib/gitlab/graphql/markdown_field_spec.rb
spec/lib/gitlab/graphql/pagination/keyset/connection_generic_keyset_spec.rb
spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb
spec/lib/gitlab/quick_actions/command_definition_spec.rb
spec/requests/api/graphql/group/dependency_proxy_manifests_spec.rb
- Missing excludes:
-
Layout/SpaceInsideParens
:- Missing excludes:
spec/lib/gitlab/ci/templates/managed_cluster_applications_gitlab_ci_yaml_spec.rb
spec/services/authorized_project_update/project_create_service_spec.rb
ee/spec/finders/ee/alert_management/alerts_finder_spec.rb
ee/spec/lib/gitlab/auth_spec.rb
spec/services/authorized_project_update/project_group_link_create_service_spec.rb
- Superfluous excludes:
app/models/alert_management/alert.rb
ee/spec/workers/security/create_orchestration_policy_worker_spec.rb
qa/spec/scenario/template_spec.rb
spec/lib/gitlab/auth/o_auth/user_spec.rb
spec/lib/gitlab/database/background_migration/batched_job_spec.rb
- Missing excludes:
-
Lint/MissingCopEnableDirective
:- Missing excludes:
lib/gitlab/background_migration/migrate_stage_status.rb
- Superfluous excludes:
lib/gitlab/task_helpers.rb
- Missing excludes:
-
Lint/MixedRegexpCaptureTypes
:- Missing excludes:
lib/gitlab/request_profiler/profile.rb
- Missing excludes:
-
Lint/RedundantCopDisableDirective
:- Missing excludes:
lib/gitlab/request_profiler.rb
- Superfluous excludes:
app/controllers/admin/dashboard_controller.rb
app/controllers/concerns/enforces_two_factor_authentication.rb
app/controllers/concerns/integrations/actions.rb
app/controllers/concerns/issues_calendar.rb
app/controllers/concerns/snippets_actions.rb
app/controllers/concerns/wiki_actions.rb
app/controllers/groups/autocomplete_sources_controller.rb
app/controllers/groups/labels_controller.rb
app/controllers/import/fogbugz_controller.rb
app/controllers/import/github_controller.rb
app/controllers/projects/issues_controller.rb
app/controllers/projects/jobs_controller.rb
app/controllers/projects/pipeline_schedules_controller.rb
app/controllers/projects/pipelines/tests_controller.rb
app/controllers/search_controller.rb
app/controllers/sessions_controller.rb
app/finders/autocomplete/acts_as_taggable_on/tags_finder.rb
app/finders/autocomplete/move_to_project_finder.rb
app/finders/autocomplete/routes_finder.rb
app/finders/autocomplete/users_finder.rb
app/finders/ci/daily_build_group_report_results_finder.rb
app/finders/groups_finder.rb
app/finders/users_finder.rb
app/graphql/resolvers/concerns/caching_array_resolver.rb
app/graphql/resolvers/project_milestones_resolver.rb
app/graphql/types/base_enum.rb
app/graphql/types/ci/runner_web_url_edge.rb
app/graphql/types/packages/helm/dependency_type.rb
app/graphql/types/projects/service_type_enum.rb
app/helpers/diff_helper.rb
app/helpers/search_helper.rb
app/models/concerns/cascading_namespace_setting_attribute.rb
app/models/concerns/from_except.rb
app/models/concerns/from_intersect.rb
app/models/concerns/from_union.rb
app/models/user.rb
app/presenters/dev_ops_report/metric_presenter.rb
app/serializers/diffs_entity.rb
app/serializers/fork_namespace_entity.rb
app/services/ci/job_artifacts/destroy_batch_service.rb
app/services/ci/register_job_service.rb
app/services/ci/retry_job_service.rb
app/services/database/consistency_check_service.rb
app/services/issues/export_csv_service.rb
app/services/labels/transfer_service.rb
app/services/projects/auto_devops/disable_service.rb
app/services/projects/open_issues_count_service.rb
app/services/spam/spam_action_service.rb
app/services/users/migrate_to_ghost_user_service.rb
app/services/web_hooks/destroy_service.rb
app/workers/authorized_project_update/user_refresh_over_user_range_worker.rb
app/workers/bulk_imports/entity_worker.rb
app/workers/container_expiration_policy_worker.rb
app/workers/create_note_diff_file_worker.rb
app/workers/expire_job_cache_worker.rb
app/workers/import_issues_csv_worker.rb
app/workers/incident_management/process_alert_worker_v2.rb
app/workers/merge_worker.rb
app/workers/remove_unaccepted_member_invites_worker.rb
config/initializers/warden.rb
config/initializers/wikicloth_redos_patch.rb
config/routes/api.rb
db/migrate/20210303193544_add_concurrent_fields_to_bulk_imports_trackers.rb
db/migrate/20210917134321_remove_temporary_index_for_project_topics_on_taggings.rb
db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb
db/post_migrate/20210610042700_remove_clusters_applications_fluentd_table.rb
db/post_migrate/20210708011426_finalize_ci_builds_metadata_bigint_conversion.rb
db/post_migrate/20210730104800_schedule_extract_project_topics_into_separate_table.rb
db/post_migrate/20210806131706_finalize_taggins_bigint_conversion.rb
db/post_migrate/20210906130643_drop_temporary_columns_and_triggers_for_taggings.rb
db/post_migrate/20211028100303_tmp_index_for_delete_issue_merge_request_taggings_records.rb
db/post_migrate/20220328100456_schedule20220328_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb
db/post_migrate/20220328100457_schedule20220328_reset_duplicate_ci_runners_token_values_on_projects.rb
ee/app/controllers/ee/groups/group_members_controller.rb
ee/app/controllers/groups/todos_controller.rb
ee/app/finders/geo/file_registry_finder.rb
ee/app/finders/geo/project_registry_finder.rb
ee/app/finders/geo/registry_finder.rb
ee/app/finders/status_page/incident_comments_finder.rb
ee/app/finders/status_page/incidents_finder.rb
ee/app/graphql/types/ci/minutes/namespace_monthly_usage_type.rb
ee/app/graphql/types/incident_management/oncall_rotation_active_period_input_type.rb
ee/app/graphql/types/scan_type.rb
ee/app/helpers/ee/boards_helper.rb
ee/app/helpers/ee/namespaces_helper.rb
ee/app/helpers/projects/on_demand_scans_helper.rb
ee/app/models/ee/vulnerability.rb
ee/app/models/geo/event_log.rb
ee/app/services/analytics/cycle_analytics/data_loader_service.rb
ee/app/services/ee/boards/issues/list_service.rb
ee/app/services/ee/search_service.rb
ee/app/services/ee/users/migrate_to_ghost_user_service.rb
ee/app/services/geo/repository_base_sync_service.rb
ee/app/workers/ee/issuable_export_csv_worker.rb
ee/app/workers/ee/namespaces/in_product_marketing_emails_worker.rb
ee/app/workers/geo/design_repository_shard_sync_worker.rb
ee/app/workers/geo/repository_shard_sync_worker.rb
ee/app/workers/geo/repository_verification/secondary/shard_worker.rb
ee/app/workers/scan_security_report_secrets_worker.rb
ee/app/workers/security/orchestration_policy_rule_schedule_worker.rb
ee/db/geo/migrate/20210504143244_add_verification_to_merge_request_diff_registry.rb
ee/lib/analytics/merge_request_metrics_calculator.rb
ee/lib/api/audit_events.rb
ee/lib/ee/api/entities/analytics/code_review/merge_request.rb
ee/lib/ee/api/settings.rb
ee/lib/ee/gitlab/usage_data.rb
ee/lib/gitlab/analytics/type_of_work/tasks_by_type.rb
ee/spec/helpers/ee/releases_helper_spec.rb
ee/spec/lib/ee/gitlab/issuable_metadata_spec.rb
ee/spec/lib/elastic/latest/project_instance_proxy_spec.rb
ee/spec/requests/api/graphql/mutations/boards/epic_boards/epic_move_list_spec.rb
ee/spec/services/security/merge_reports_service_spec.rb
ee/spec/support/shared_examples/models/elasticsearch_indexed_container_shared_examples.rb
ee/spec/support/shared_examples/models/geo_verifiable_registry_shared_examples.rb
lib/api/api.rb
lib/api/ci/variables.rb
lib/api/entities/environment.rb
lib/api/entities/issuable_time_stats.rb
lib/api/helpers.rb
lib/bulk_imports/common/transformers/user_reference_transformer.rb
lib/bulk_imports/pipeline/runner.rb
lib/container_registry/tag.rb
lib/event_filter.rb
lib/gitlab/analytics/cycle_analytics/aggregated/base_query_builder.rb
lib/gitlab/analytics/cycle_analytics/base_query_builder.rb
lib/gitlab/analytics/cycle_analytics/records_fetcher.rb
lib/gitlab/background_migration/backfill_issue_search_data.rb
lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb
lib/gitlab/background_migration/fix_merge_request_diff_commit_users.rb
lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner.rb
lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb
lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb
lib/gitlab/bitbucket_import/importer.rb
lib/gitlab/cache/request_cache.rb
lib/gitlab/ci/build/artifacts/metadata/entry.rb
lib/gitlab/ci/pipeline/duration.rb
lib/gitlab/ci/reports/accessibility_reports.rb
lib/gitlab/ci/reports/test_reports.rb
lib/gitlab/ci/reports/test_reports_comparer.rb
lib/gitlab/ci/reports/test_suite.rb
lib/gitlab/ci/reports/test_suite_summary.rb
lib/gitlab/composer/cache.rb
lib/gitlab/database/consistency_checker.rb
lib/gitlab/database/migration.rb
lib/gitlab/database/rename_reserved_paths_migration/v1/rename_namespaces.rb
lib/gitlab/diff/file.rb
lib/gitlab/diff/file_collection/merge_request_diff_batch.rb
lib/gitlab/diff/pair_selector.rb
lib/gitlab/diff/parser.rb
lib/gitlab/encrypted_ldap_command.rb
lib/gitlab/encrypted_smtp_command.rb
lib/gitlab/git/patches/collection.rb
lib/gitlab/github_import/user_finder.rb
lib/gitlab/gitlab_import/importer.rb
lib/gitlab/graphql/pagination/keyset/connection.rb
lib/gitlab/legacy_github_import/user_formatter.rb
lib/gitlab/object_hierarchy.rb
lib/gitlab/pagination/keyset/pager.rb
lib/gitlab/performance_bar/redis_adapter_when_peek_enabled.rb
lib/gitlab/profiler.rb
lib/gitlab/project_search_results.rb
lib/gitlab/redis/hll.rb
lib/gitlab/slash_commands/issue_search.rb
lib/gitlab/usage_data.rb
lib/gitlab/usage_data_queries.rb
lib/gitlab/utils/usage_data.rb
sidekiq_cluster/cli.rb
sidekiq_cluster/sidekiq_cluster.rb
spec/frontend/fixtures/merge_requests.rb
spec/helpers/releases_helper_spec.rb
spec/lib/gitlab/avatar_cache_spec.rb
spec/lib/gitlab/background_migration/batching_strategies/backfill_issue_work_item_type_batching_strategy_spec.rb
spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb
spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects_spec.rb
spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects_spec.rb
spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb
spec/lib/gitlab/git/tree_spec.rb
spec/lib/gitlab/pagination/keyset/iterator_spec.rb
spec/lib/gitlab/shard_health_cache_spec.rb
spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb
spec/lib/gitlab/sidekiq_middleware/size_limiter/server_spec.rb
spec/metrics_server/metrics_server_spec.rb
spec/models/ci/build_trace_chunk_spec.rb
spec/models/namespace/package_setting_spec.rb
spec/models/namespace_spec.rb
spec/requests/api/alert_management_alerts_spec.rb
spec/rubocop/cop/ruby_interpolation_in_translation_spec.rb
spec/services/alert_management/metric_images/upload_service_spec.rb
spec/services/suggestions/apply_service_spec.rb
spec/support/helpers/snowplow_helpers.rb
spec/support/helpers/wait_for_requests.rb
spec/support/shared_examples/models/boards/listable_shared_examples.rb
spec/support/shared_examples/models/concerns/incident_management/escalatable_shared_examples.rb
spec/support/shared_examples/models/packages/debian/distribution_key_shared_examples.rb
spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb
spec/uploaders/packages/composer/cache_uploader_spec.rb
tooling/danger/product_intelligence.rb
tooling/lib/tooling/helm3_client.rb
tooling/lib/tooling/kubernetes_client.rb
tooling/rspec_flaky/listener.rb
- Missing excludes:
-
Metrics/AbcSize
:- Superfluous excludes:
ee/lib/ee/audit/project_changes_auditor.rb
- Superfluous excludes:
-
Metrics/PerceivedComplexity
:- Superfluous excludes:
qa/qa/specs/runner.rb
- Superfluous excludes:
-
Migration/BackgroundMigrationBaseClass
:- Missing excludes:
lib/gitlab/background_migration/migrate_stage_status.rb
- Superfluous excludes:
lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb
lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb
lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb
lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb
lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb
- Missing excludes:
-
Naming/RescuedExceptionsVariableName
:- Missing excludes:
ee/app/services/namespaces/deactivate_members_over_limit_service.rb
ee/app/services/namespaces/remove_project_group_links_outside_hierarchy_service.rb
ee/app/services/namespaces/update_prevent_sharing_outside_hierarchy_service.rb
ee/app/workers/namespaces/free_user_cap_worker.rb
- Superfluous excludes:
lib/api/environments.rb
- Missing excludes:
-
Performance/ActiveRecordSubtransactionMethods
:- Missing excludes:
app/models/x509_commit_signature.rb
db/migrate/20200212014653_rename_security_dashboard_feature_flag_to_instance_security_dashboard.rb
db/post_migrate/20200214034836_remove_security_dashboard_feature_flag.rb
ee/app/services/security/store_report_service.rb
- Superfluous excludes:
app/controllers/clusters/clusters_controller.rb
app/models/merge_request.rb
app/services/packages/rubygems/metadata_extraction_service.rb
app/services/service_ping/submit_service.rb
db/post_migrate/20210824174615_prepare_ci_builds_metadata_and_ci_build_async_indexes.rb
ee/app/models/ci/minutes/namespace_monthly_usage.rb
ee/app/models/ee/iteration.rb
lib/gitlab/database/async_indexes/migration_helpers.rb
- Missing excludes:
-
Performance/BlockGivenWithExplicitBlock
:- Superfluous excludes:
app/services/projects/open_issues_count_service.rb
qa/qa/runtime/browser.rb
- Superfluous excludes:
-
Performance/ConstantRegexp
:- Superfluous excludes:
spec/scripts/lib/glfm/update_specification_spec.rb
- Superfluous excludes:
-
Performance/StringInclude
:- Superfluous excludes:
qa/qa/specs/runner.rb
- Superfluous excludes:
-
RSpec/AnyInstanceOf
:- Missing excludes:
spec/services/ci/retry_build_service_spec.rb
ee/spec/lib/gitlab/ci/templates/api_fuzzing_gitlab_ci_yaml_spec.rb
ee/spec/lib/security/ci_configuration/sast_build_actions_spec.rb
ee/spec/migrations/schedule_populate_resolved_on_default_branch_column_spec.rb
ee/spec/migrations/update_location_fingerprint_column_for_cs_spec.rb
ee/spec/migrations/update_occurrence_severity_column_spec.rb
ee/spec/migrations/update_undefined_confidence_from_occurrences_spec.rb
ee/spec/migrations/update_undefined_confidence_from_vulnerabilities_spec.rb
ee/spec/migrations/update_vulnerability_severity_column_spec.rb
ee/spec/presenters/projects/security/configuration_presenter_spec.rb
ee/spec/requests/api/graphql/mutations/pipelines/run_dast_scan_spec.rb
ee/spec/services/ci/expire_pipeline_cache_service_spec.rb
ee/spec/services/ci/run_dast_scan_service_spec.rb
ee/spec/services/ee/security/ingress_modsecurity_usage_service_spec.rb
ee/spec/workers/build_finished_worker_spec.rb
spec/controllers/registrations/experience_levels_controller_spec.rb
spec/features/projects/pages_spec.rb
spec/features/projects/services/user_activates_mattermost_slash_command_spec.rb
spec/helpers/analytics/unique_visits_helper_spec.rb
spec/lib/gitlab/background_migration/populate_personal_snippet_statistics_spec.rb
spec/lib/gitlab/background_migration/populate_project_snippet_statistics_spec.rb
spec/lib/gitlab/cycle_analytics/base_event_fetcher_spec.rb
spec/lib/gitlab/database/multi_threaded_migration_spec.rb
spec/lib/gitlab/patch/action_dispatch_journey_formatter_spec.rb
spec/lib/gitlab/tracking/destinations/product_analytics_spec.rb
spec/serializers/analytics_stage_serializer_spec.rb
spec/services/ci/destroy_expired_job_artifacts_service_spec.rb
spec/services/ci/stop_environments_service_spec.rb
spec/services/pages/delete_services_spec.rb
spec/workers/build_coverage_worker_spec.rb
spec/workers/build_trace_sections_worker_spec.rb
spec/workers/pages_remove_worker_spec.rb
- Superfluous excludes:
ee/spec/controllers/projects/environments_controller_spec.rb
ee/spec/controllers/trials_controller_spec.rb
ee/spec/features/boards/scoped_issue_board_spec.rb
ee/spec/features/groups/navbar_spec.rb
ee/spec/features/groups/saml_providers_spec.rb
ee/spec/lib/gitlab/ci/templates/Jobs/browser_performance_testing_gitlab_ci_yaml_spec.rb
ee/spec/lib/gitlab/ci/templates/Jobs/dast_default_branch_gitlab_ci_yaml_spec.rb
ee/spec/lib/gitlab/ci/templates/Jobs/load_performance_testing_gitlab_ci_yaml_spec.rb
ee/spec/lib/gitlab/ci/templates/Verify/browser_performance_testing_gitlab_ci_yaml_spec.rb
ee/spec/lib/gitlab/ci/templates/Verify/load_performance_testing_gitlab_ci_yaml_spec.rb
ee/spec/lib/gitlab/ci/templates/container_scanning_gitlab_ci_yaml_spec.rb
ee/spec/lib/gitlab/ci/templates/coverage_fuzzing_gitlab_ci_yaml_spec.rb
ee/spec/lib/gitlab/ci/templates/dast_gitlab_ci_yaml_spec.rb
ee/spec/lib/gitlab/ci/templates/dependency_scanning_gitlab_ci_yaml_spec.rb
ee/spec/lib/gitlab/ci/templates/license_scanning_gitlab_ci_yaml_spec.rb
ee/spec/lib/gitlab/ci/templates/sast_gitlab_ci_yaml_spec.rb
ee/spec/lib/gitlab/elastic/project_search_results_spec.rb
ee/spec/lib/gitlab/expiring_subscription_message_spec.rb
ee/spec/lib/omni_auth/strategies/group_saml_spec.rb
ee/spec/lib/system_check/geo/geo_database_configured_check_spec.rb
ee/spec/requests/api/graphql/mutations/dast_on_demand_scans/create_spec.rb
ee/spec/requests/api/graphql/mutations/dast_site_profiles/delete_spec.rb
ee/spec/services/geo/wiki_sync_service_spec.rb
qa/spec/runtime/release_spec.rb
spec/controllers/projects/issues_controller_spec.rb
spec/features/profiles/personal_access_tokens_spec.rb
spec/features/projects/navbar_spec.rb
spec/lib/gitlab/checks/diff_check_spec.rb
spec/lib/gitlab/email/handler/create_note_handler_spec.rb
spec/lib/gitlab/fogbugz_import/importer_spec.rb
spec/lib/gitlab/metrics/subscribers/active_record_spec.rb
spec/lib/gitlab/sidekiq_middleware_spec.rb
spec/models/hooks/web_hook_spec.rb
spec/models/integrations/mattermost_slash_commands_spec.rb
spec/models/issue_spec.rb
spec/requests/api/graphql_spec.rb
spec/requests/api/pages/pages_spec.rb
spec/services/boards/lists/update_service_spec.rb
spec/services/ci/expire_pipeline_cache_service_spec.rb
spec/services/integrations/test/project_service_spec.rb
spec/services/packages/nuget/update_package_from_metadata_service_spec.rb
spec/services/projects/prometheus/alerts/notify_service_spec.rb
spec/services/test_hooks/project_service_spec.rb
spec/services/test_hooks/system_service_spec.rb
spec/services/users/migrate_to_ghost_user_service_spec.rb
spec/support/helpers/test_env.rb
spec/support/shared_examples/controllers/unique_visits_shared_examples.rb
spec/support/shared_examples/services/alert_management_shared_examples.rb
spec/support/shared_examples/services/boards/boards_list_service_shared_examples.rb
spec/support/snowplow.rb
spec/tasks/gitlab/git_rake_spec.rb
spec/workers/pipeline_hooks_worker_spec.rb
spec/workers/stuck_ci_jobs_worker_spec.rb
- Missing excludes:
-
RSpec/ContextWording
:- Missing excludes:
ee/spec/lib/gitlab/geo/replication/file_transfer_spec.rb
ee/spec/lib/gitlab/geo/replication/job_artifact_transfer_spec.rb
ee/spec/uploaders/every_gitlab_uploader_spec.rb
ee/spec/lib/gitlab/geo/replication/file_downloader_spec.rb
ee/spec/lib/gitlab/geo/replication/job_artifact_downloader_spec.rb
ee/spec/services/geo/file_download_service_spec.rb
ee/spec/lib/gitlab/geo/replication/file_retriever_spec.rb
ee/spec/finders/ee/alert_management/alerts_finder_spec.rb
ee/spec/services/ee/service_ping/build_payload_service_spec.rb
ee/spec/services/ee/service_ping/permit_data_categories_service_spec.rb
ee/spec/services/geo/file_upload_service_spec.rb
ee/spec/workers/geo/file_download_dispatch_worker_spec.rb
spec/lib/gitlab/diff/custom_diff_spec.rb
spec/services/prometheus/create_default_alerts_service_spec.rb
spec/workers/expire_build_instance_artifacts_worker_spec.rb
- Superfluous excludes:
ee/spec/helpers/ee/application_settings_helper_spec.rb
ee/spec/lib/gitlab/patch/database_config_spec.rb
ee/spec/models/compliance_management/framework_spec.rb
ee/spec/models/geo/job_artifact_registry_spec.rb
spec/controllers/repositories/git_http_controller_spec.rb
spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb
spec/workers/prometheus/create_default_alerts_worker_spec.rb
- Missing excludes:
-
RSpec/EmptyExampleGroup
:- Superfluous excludes:
ee/spec/services/personal_access_tokens/revoke_invalid_tokens_spec.rb
- Superfluous excludes:
-
RSpec/ExpectChange
:- Missing excludes:
ee/spec/services/geo/file_download_service_spec.rb
ee/spec/services/namespaces/update_prevent_sharing_outside_hierarchy_service_spec.rb
- Superfluous excludes:
spec/models/commit_signatures/gpg_signature_spec.rb
spec/models/commit_signatures/x509_commit_signature_spec.rb
- Missing excludes:
-
RSpec/ExpectInHook
:- Missing excludes:
ee/spec/lib/gitlab/geo/replication/job_artifact_retriever_spec.rb
spec/services/projects/after_import_service_spec.rb
- Superfluous excludes:
spec/features/issues/filtered_search/dropdown_hint_spec.rb
spec/features/projects/clusters/gcp_spec.rb
spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb
- Missing excludes:
-
RSpec/InstanceVariable
:- Missing excludes:
qa/qa/specs/features/ee/browser_ui/4_verify/cancelling_merge_request_in_merge_train_spec.rb
- Superfluous excludes:
qa/qa/specs/features/api/1_manage/import_large_github_repo_spec.rb
qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_file_size_spec.rb
qa/qa/specs/features/ee/browser_ui/13_secure/vulnerability_management_spec.rb
spec/controllers/admin/clusters_controller_spec.rb
spec/controllers/groups/clusters_controller_spec.rb
spec/controllers/projects/clusters_controller_spec.rb
spec/requests/api/merge_requests_spec.rb
- Missing excludes:
-
RSpec/MultipleMemoizedHelpers
:- Missing excludes:
spec/lib/gitlab/background_migration/populate_finding_uuid_for_vulnerability_feedback_spec.rb
ee/spec/services/security/store_report_service_spec.rb
- Superfluous excludes:
spec/requests/api/ci/runner/jobs_artifacts_spec.rb
- Missing excludes:
-
RSpec/PredicateMatcher
:- Missing excludes:
ee/spec/lib/gitlab/geo/replication/file_transfer_spec.rb
spec/lib/gitlab/diff/custom_diff_spec.rb
spec/workers/expire_build_instance_artifacts_worker_spec.rb
ee/spec/lib/gitlab/geo/replication/base_transfer_spec.rb
ee/spec/presenters/ci/minutes/quota_presenter_spec.rb
- Missing excludes:
-
RSpec/RepeatedExampleGroupDescription
:- Superfluous excludes:
ee/spec/policies/project_policy_spec.rb
ee/spec/requests/api/graphql/vulnerabilities/sort_spec.rb
- Superfluous excludes:
-
RSpec/ReturnFromStub
:- Missing excludes:
ee/spec/lib/gitlab/geo/replication/file_transfer_spec.rb
ee/spec/workers/geo/file_download_dispatch_worker_spec.rb
ee/spec/lib/gitlab/geo/replication/base_transfer_spec.rb
ee/spec/services/geo/job_artifact_deleted_event_store_spec.rb
ee/spec/services/network_policies/resources_service_spec.rb
- Superfluous excludes:
ee/spec/lib/gitlab/code_owners_spec.rb
spec/lib/gitlab/metrics/rails_slis_spec.rb
- Missing excludes:
-
RSpec/ScatteredLet
:- Missing excludes:
ee/spec/models/ci/minutes/quota_spec.rb
- Superfluous excludes:
spec/lib/gitlab/usage/service_ping_report_spec.rb
- Missing excludes:
-
RSpec/TimecopFreeze
:- Superfluous excludes:
spec/models/active_session_spec.rb
spec/support/shared_examples/workers/concerns/reenqueuer_shared_examples.rb
- Superfluous excludes:
-
RSpec/VerifiedDoubles
:- Missing excludes:
ee/spec/lib/gitlab/geo/replication/job_artifact_transfer_spec.rb
ee/spec/lib/gitlab/geo/replication/job_artifact_retriever_spec.rb
ee/spec/lib/system_check/app/elasticsearch_check_spec.rb
ee/spec/requests/api/alert_management_alerts_spec.rb
ee/spec/serializers/merge_request_compliance_entity_spec.rb
ee/spec/services/ee/service_ping/service_ping_settings_spec.rb
spec/services/service_ping/service_ping_settings_spec.rb
ee/spec/services/ee/service_ping/build_payload_service_spec.rb
ee/spec/services/ee/service_ping/permit_data_categories_service_spec.rb
ee/spec/lib/gitlab/patch/legacy_database_config_spec.rb
ee/spec/models/concerns/ee/sha_attribute_spec.rb
qa/spec/support/shared_examples/scenario_shared_examples.rb
spec/lib/backup/gitaly_rpc_backup_spec.rb
spec/lib/constraints/feature_constrainer_spec.rb
spec/lib/gitlab/graphql/find_argument_in_parent_spec.rb
spec/lib/gitlab/metrics/exporter/health_checks_middleware_spec.rb
spec/models/concerns/sha256_attribute_spec.rb
spec/services/import/gitlab_projects/create_project_from_remote_file_service_spec.rb
spec/services/namespaces/invite_team_email_service_spec.rb
spec/services/service_ping/build_payload_service_spec.rb
spec/services/service_ping/permit_data_categories_service_spec.rb
- Superfluous excludes:
ee/spec/elastic/migrate/20210510113500_delete_merge_requests_from_original_index_spec.rb
ee/spec/elastic/migrate/20210510143200_delete_notes_from_original_index_spec.rb
ee/spec/graphql/ee/resolvers/board_lists_resolver_spec.rb
ee/spec/graphql/mutations/merge_requests/accept_spec.rb
ee/spec/graphql/resolvers/board_groupings/epics_resolvers_spec.rb
ee/spec/graphql/types/network_policy_type_spec.rb
ee/spec/graphql/types/security/training_type_spec.rb
ee/spec/services/ee/ci/job_artifacts/destroy_all_expired_service_spec.rb
ee/spec/services/ee/ci/job_artifacts/destroy_batch_service_spec.rb
qa/spec/scenario/template_spec.rb
qa/spec/specs/allure_report_spec.rb
spec/features/projects/clusters/gcp_spec.rb
spec/features/projects/clusters_spec.rb
spec/graphql/mutations/concerns/mutations/finds_by_gid_spec.rb
spec/graphql/mutations/merge_requests/accept_spec.rb
spec/graphql/mutations/merge_requests/create_spec.rb
spec/graphql/resolvers/design_management/versions_resolver_spec.rb
spec/graphql/types/range_input_type_spec.rb
spec/lib/gitlab/database/background_migration/batched_migration_wrapper_spec.rb
spec/lib/gitlab/error_tracking_spec.rb
spec/lib/gitlab/graphql/pagination/keyset/connection_generic_keyset_spec.rb
spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb
spec/lib/gitlab/usage/service_ping/payload_keys_processor_spec.rb
spec/models/commit_signatures/gpg_signature_spec.rb
spec/models/concerns/sha_attribute_spec.rb
spec/models/project_import_state_spec.rb
spec/services/service_ping/submit_service_ping_service_spec.rb
- Missing excludes:
-
Rails/FilePath
:- Missing excludes:
ee/spec/uploaders/every_gitlab_uploader_spec.rb
- Missing excludes:
-
Rails/Pluck
:- Missing excludes:
app/services/prometheus/create_default_alerts_service.rb
ee/app/workers/geo/file_download_dispatch_worker.rb
- Superfluous excludes:
ee/app/models/vulnerabilities/finding.rb
- Missing excludes:
-
Rails/RedundantForeignKey
:- Missing excludes:
ee/app/models/incident_management/timeline_event.rb
- Missing excludes:
-
Rails/SkipsModelValidations
:- Missing excludes:
ee/spec/lib/gitlab/geo/replication/file_transfer_spec.rb
ee/app/services/geo/job_artifact_deleted_event_store.rb
ee/spec/lib/gitlab/geo/replication/file_downloader_spec.rb
ee/spec/lib/gitlab/geo/replication/job_artifact_downloader_spec.rb
ee/spec/services/geo/file_download_service_spec.rb
ee/spec/workers/network_policy_metrics_worker_spec.rb
spec/features/projects/members/invite_group_spec.rb
- Superfluous excludes:
app/services/merge_requests/base_service.rb
app/services/merge_requests/handle_assignees_change_service.rb
ee/spec/models/ee/key_spec.rb
spec/features/projects/jobs/user_browses_jobs_spec.rb
- Missing excludes:
-
Rails/TimeZone
:- Missing excludes:
ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_time_summary_spec.rb
ee/spec/lib/gitlab/background_migration/fix_orphan_promoted_issues_spec.rb
ee/spec/lib/gitlab/geo/log_cursor/events/job_artifact_deleted_event_spec.rb
ee/spec/lib/gitlab/geo/log_cursor/events/lfs_object_deleted_event_spec.rb
lib/gitlab/kubernetes/helm/certificate.rb
spec/lib/gitlab/background_migration/recalculate_project_authorizations_spec.rb
spec/lib/gitlab/background_migration/wrongfully_confirmed_email_unconfirmer_spec.rb
spec/lib/gitlab/cycle_analytics/usage_data_spec.rb
spec/lib/gitlab/omniauth_logging/json_formatter_spec.rb
- Superfluous excludes:
ee/lib/gitlab/geo/base_request.rb
lib/gitlab/ci/ansi2json/line.rb
lib/gitlab/ci/pipeline/chain/sequence.rb
lib/gitlab/cycle_analytics/summary/deployment_frequency.rb
lib/gitlab/grape_logging/loggers/queue_duration_logger.rb
lib/gitlab/instrumentation/redis_interceptor.rb
tooling/rspec_flaky/flaky_example.rb
tooling/rspec_flaky/report.rb
spec/lib/gitlab/github_import/importer/diff_note_importer_spec.rb
spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/until_executing_spec.rb
spec/tooling/rspec_flaky/flaky_example_spec.rb
spec/tooling/rspec_flaky/listener_spec.rb
spec/tooling/rspec_flaky/report_spec.rb
- Missing excludes:
-
Style/EmptyElse
:- Superfluous excludes:
app/graphql/types/packages/package_type.rb
- Superfluous excludes:
-
Style/EmptyMethod
:- Superfluous excludes:
app/controllers/projects/ci/secure_files_controller.rb
spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb
- Superfluous excludes:
-
Style/ExplicitBlockArgument
:- Superfluous excludes:
qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_file_size_spec.rb
- Superfluous excludes:
-
Style/FormatString
:- Missing excludes:
ee/app/components/namespaces/preview_free_user_cap_alert_component.rb
ee/app/services/network_policies/responses.rb
- Missing excludes:
-
Style/GuardClause
:- Missing excludes:
app/finders/projects/serverless/functions_finder.rb
ee/lib/pseudonymizer/dumper.rb
lib/gitlab/diff/custom_diff.rb
- Superfluous excludes:
app/helpers/appearances_helper.rb
app/models/merge_request_assignee.rb
app/models/merge_request_reviewer.rb
app/workers/cleanup_container_repository_worker.rb
ee/app/services/ee/merge_requests/post_merge_service.rb
lib/gitlab/database/load_balancing/configuration.rb
- Missing excludes:
-
Style/HashEachMethods
:- Superfluous excludes:
spec/lib/gitlab/template/gitlab_ci_yml_template_spec.rb
- Superfluous excludes:
-
Style/IfInsideElse
:- Missing excludes:
app/services/service_ping/build_payload_service.rb
- Missing excludes:
-
Style/IfUnlessModifier
:- Missing excludes:
ee/lib/pseudonymizer/dumper.rb
lib/gitlab/diff/custom_diff.rb
ee/lib/gitlab/geo/replication/base_transfer.rb
app/controllers/admin/requests_profiles_controller.rb
app/services/service_ping/devops_report_service.rb
ee/app/finders/ee/alert_management/alerts_finder.rb
ee/app/services/epic_links/create_service.rb
ee/app/services/epic_links/update_service.rb
ee/lib/pseudonymizer/uploader.rb
rubocop/cop/migration/hash_index.rb
- Superfluous excludes:
app/controllers/admin/runners_controller.rb
app/controllers/jira_connect/application_controller.rb
app/controllers/projects/services_controller.rb
app/graphql/mutations/work_items/create.rb
app/helpers/appearances_helper.rb
app/models/concerns/limitable.rb
app/services/bulk_imports/file_decompression_service.rb
app/services/merge_requests/mergeability/run_checks_service.rb
app/workers/cleanup_container_repository_worker.rb
config/initializers/content_security_policy.rb
ee/app/graphql/ee/mutations/issues/create.rb
ee/app/models/ee/member.rb
ee/app/models/ee/namespace/root_storage_size.rb
ee/app/models/ee/vulnerability.rb
ee/app/services/audit_events/runner_audit_event_service.rb
ee/app/services/ee/merge_requests/base_service.rb
ee/app/services/projects/slack_application_install_service.rb
ee/app/workers/ee/post_receive.rb
ee/lib/analytics/devops_adoption/snapshot_calculator.rb
lib/api/ci/secure_files.rb
lib/api/project_clusters.rb
lib/backup/manager.rb
lib/gitlab/git_access_wiki.rb
lib/gitlab/import_export/file_importer.rb
lib/gitlab/metrics/rails_slis.rb
lib/gitlab/template/gitlab_ci_yml_template.rb
lib/gitlab/usage/metrics/aggregates/aggregate.rb
qa/qa/git/repository.rb
qa/qa/runtime/browser.rb
qa/qa/scenario/template.rb
- Missing excludes:
-
Style/Lambda
:- Superfluous excludes:
app/graphql/types/permission_types/base_permission_type.rb
spec/lib/gitlab/database/query_analyzers/gitlab_schemas_metrics_spec.rb
- Superfluous excludes:
-
Style/Next
:- Missing excludes:
app/finders/projects/serverless/functions_finder.rb
- Missing excludes:
-
Style/NumericLiteralPrefix
:- Missing excludes:
ee/lib/gitlab/geo/replication/base_transfer.rb
ee/spec/lib/gitlab/geo/replication/file_transfer_spec.rb
ee/spec/lib/gitlab/geo/replication/job_artifact_transfer_spec.rb
ee/spec/models/ci/minutes/quota_spec.rb
- Missing excludes:
-
Style/OpenStructUse
:- Superfluous excludes:
lib/gitlab/testing/request_inspector_middleware.rb
spec/helpers/application_settings_helper_spec.rb
spec/services/system_note_service_spec.rb
- Superfluous excludes:
-
Style/PercentLiteralDelimiters
:- Missing excludes:
ee/lib/gitlab/alert_management/payload/cilium.rb
ee/lib/banzai/pipeline/incident_management/timeline_event_pipeline.rb
ee/lib/ee/gitlab/integrations/sti_type.rb
ee/spec/lib/banzai/pipeline/incident_management/timeline_event_pipeline_spec.rb
spec/lib/gitlab/kubernetes/network_policy_spec.rb
- Superfluous excludes:
app/models/integrations/base_ci.rb
ee/lib/api/managed_licenses.rb
ee/spec/lib/ee/gitlab/elastic/helper_spec.rb
lib/gitlab/process_supervisor.rb
qa/qa/git/repository.rb
qa/qa/runtime/browser.rb
spec/controllers/admin/clusters_controller_spec.rb
spec/db/schema_spec.rb
- Missing excludes:
-
Style/RedundantSelf
:- Missing excludes:
ee/lib/gitlab/alert_management/payload/cilium.rb
ee/lib/system_check/app/elasticsearch_check.rb
lib/gitlab/kubernetes/cilium_network_policy.rb
lib/gitlab/kubernetes/network_policy.rb
- Superfluous excludes:
app/models/merge_request_assignee.rb
app/models/merge_request_reviewer.rb
qa/qa/git/repository.rb
- Missing excludes:
-
Style/SingleArgumentDig
:- Superfluous excludes:
lib/gitlab/ci/badge/pipeline/template.rb
lib/gitlab/ci/badge/release/template.rb
- Superfluous excludes:
-
Style/SoleNestedConditional
:- Superfluous excludes:
app/services/ci/register_job_service.rb
- Superfluous excludes:
-
Style/StringLiteralsInInterpolation
:- Missing excludes:
ee/lib/pseudonymizer/pager.rb
spec/controllers/projects/serverless/functions_controller_spec.rb
- Missing excludes:
-
Style/SymbolProc
:- Superfluous excludes:
ee/app/workers/repository_push_audit_event_worker.rb
- Superfluous excludes: