Remove "::" from namespace part of strings in translation
Crowdin QA issues sometimes complain about missing variables in the translations of these strings because of the use of ":" in the namespace part of the string.
What is the reason for the ::'s ?
Would it be any problem to just remove them so the following strings:
Metrics::Dashboard::Annotation|Annotation can't belong to both a cluster and an environment at the same time
Metrics::Dashboard::Annotation|Annotation has not been deleted
Metrics::Dashboard::Annotation|Annotation must belong to a cluster or an environment
Metrics::Dashboard::Annotation|Dashboard with requested path can not be found
Metrics::Dashboard::Annotation|You are not authorized to create annotation for selected cluster
Metrics::Dashboard::Annotation|You are not authorized to create annotation for selected environment
Metrics::Dashboard::Annotation|You are not authorized to delete this annotation
Metrics::Dashboard::Annotation|can't be before starting_at time
Metrics::UsersStarredDashboards|Dashboard with requested path can not be found
Metrics::UsersStarredDashboards|You are not authorized to add star to this dashboard
Will become:
MetricsDashboardAnnotation|Annotation can't belong to both a cluster and an environment at the same time
MetricsDashboardAnnotation|Annotation has not been deleted
MetricsDashboardAnnotation|Annotation must belong to a cluster or an environment
MetricsDashboardAnnotation|Dashboard with requested path can not be found
MetricsDashboardAnnotation|You are not authorized to create annotation for selected cluster
MetricsDashboardAnnotation|You are not authorized to create annotation for selected environment
MetricsDashboardAnnotation|You are not authorized to delete this annotation
MetricsDashboardAnnotation|can't be before starting_at time
MetricsUsersStarredDashboards|Dashboard with requested path can not be found
MetricsUsersStarredDashboards|You are not authorized to add star to this dashboard
That way Crowdin will not complain and translators would not have to see the QA issues. And the namespaces in translation will be more consistent/less confusion for translators.
https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/models/metrics/dashboard/annotation.rb#L35-47 https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/services/metrics/dashboard/annotations/create_service.rb#L33-54 https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/services/metrics/dashboard/annotations/delete_service.rb#L30-38 https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/services/metrics/users_starred_dashboards/create_service.rb#L38-47