Remove `deprecated` metric status
Related to #335894 (closed).
Proposal
Metric definition deprecated
status should be removed to simplify the metric lifecycle. This requires existing deprecated
metrics to be removed
. To comply with the current metric removal policy, we need to check with the Data team if the metrics are safe to remove.
-
Create issues for the Data team to check if deprecated metrics are used in any Sisense dashboard and are safe to remove. Some of them already have an issue #331584 (closed) and a corresponding issue for the Data team (https://gitlab.com/gitlab-data/analytics/-/issues/10061). -
Change the deprecated
metrics toremoved
and remove thedeprecated
status from the metric JSON schema. (MR) -
Update the documentation to change the metric lifecycle guidelines and remove other mentions of the deprecated
status. (MR)
At the time of writing, the following deprecated metrics need to be removed:
All deprecated metrics
Gitlab::Usage::MetricDefinition.definitions.select { |k, m| m.status == "deprecated" }.keys.sort
=> ["counts.package_events_i_package_container_delete_package",
"counts.package_events_i_package_container_pull_package",
"counts.package_events_i_package_container_push_package",
"counts.package_events_i_package_debian_push_package",
"counts.package_events_i_package_tag_delete_package",
"counts.package_events_i_package_tag_pull_package",
"counts.package_events_i_package_tag_push_package",
"redis_hll_counters.deploy_token_packages.i_package_composer_deploy_token_weekly",
"redis_hll_counters.deploy_token_packages.i_package_container_deploy_token_monthly",
"redis_hll_counters.deploy_token_packages.i_package_container_deploy_token_weekly",
"redis_hll_counters.deploy_token_packages.i_package_debian_deploy_token_monthly",
"redis_hll_counters.deploy_token_packages.i_package_debian_deploy_token_weekly",
"redis_hll_counters.deploy_token_packages.i_package_golang_deploy_token_monthly",
"redis_hll_counters.deploy_token_packages.i_package_golang_deploy_token_weekly",
"redis_hll_counters.deploy_token_packages.i_package_tag_deploy_token_monthly",
"redis_hll_counters.deploy_token_packages.i_package_tag_deploy_token_weekly",
"redis_hll_counters.user_packages.i_package_container_user_monthly",
"redis_hll_counters.user_packages.i_package_container_user_weekly",
"redis_hll_counters.user_packages.i_package_debian_user_monthly",
"redis_hll_counters.user_packages.i_package_debian_user_weekly",
"redis_hll_counters.user_packages.i_package_golang_user_monthly",
"redis_hll_counters.user_packages.i_package_golang_user_weekly",
"redis_hll_counters.user_packages.i_package_tag_user_monthly",
"redis_hll_counters.user_packages.i_package_tag_user_weekly",
"usage_activity_by_stage.manage.bulk_imports.gitlab",
"usage_activity_by_stage.manage.groups_imported",
"usage_activity_by_stage.manage.issues_imported.csv",
"usage_activity_by_stage.manage.issues_imported.fogbugz",
"usage_activity_by_stage.manage.issues_imported.jira",
"usage_activity_by_stage.manage.issues_imported.phabricator",
"usage_activity_by_stage.manage.projects_imported.bitbucket",
"usage_activity_by_stage.manage.projects_imported.bitbucket_server",
"usage_activity_by_stage.manage.projects_imported.git",
"usage_activity_by_stage.manage.projects_imported.gitea",
"usage_activity_by_stage.manage.projects_imported.github",
"usage_activity_by_stage.manage.projects_imported.gitlab",
"usage_activity_by_stage.manage.projects_imported.gitlab_project",
"usage_activity_by_stage.manage.projects_imported.manifest",
"usage_activity_by_stage.manage.projects_imported.total",
"usage_activity_by_stage.secure.user_api_fuzzing_scans",
"usage_activity_by_stage.secure.user_cluster_image_scanning_scans",
"usage_activity_by_stage.secure.user_container_scanning_scans",
"usage_activity_by_stage.secure.user_coverage_fuzzing_scans",
"usage_activity_by_stage.secure.user_dast_scans",
"usage_activity_by_stage.secure.user_dependency_scanning_scans",
"usage_activity_by_stage.secure.user_sast_scans",
"usage_activity_by_stage.secure.user_secret_detection_scans",
"usage_activity_by_stage_monthly.manage.bulk_imports.gitlab",
"usage_activity_by_stage_monthly.manage.groups_imported",
"usage_activity_by_stage_monthly.manage.issues_imported.csv",
"usage_activity_by_stage_monthly.manage.issues_imported.fogbugz",
"usage_activity_by_stage_monthly.manage.issues_imported.jira",
"usage_activity_by_stage_monthly.manage.issues_imported.phabricator",
"usage_activity_by_stage_monthly.manage.projects_imported.bitbucket",
"usage_activity_by_stage_monthly.manage.projects_imported.bitbucket_server",
"usage_activity_by_stage_monthly.manage.projects_imported.git",
"usage_activity_by_stage_monthly.manage.projects_imported.gitea",
"usage_activity_by_stage_monthly.manage.projects_imported.github",
"usage_activity_by_stage_monthly.manage.projects_imported.gitlab",
"usage_activity_by_stage_monthly.manage.projects_imported.gitlab_project",
"usage_activity_by_stage_monthly.manage.projects_imported.manifest",
"usage_activity_by_stage_monthly.manage.projects_imported.total",
"usage_activity_by_stage_monthly.monitor.projects_incident_sla_enabled",
"usage_activity_by_stage_monthly.secure.user_api_fuzzing_scans",
"usage_activity_by_stage_monthly.secure.user_cluster_image_scanning_scans",
"usage_activity_by_stage_monthly.secure.user_container_scanning_scans",
"usage_activity_by_stage_monthly.secure.user_coverage_fuzzing_scans",
"usage_activity_by_stage_monthly.secure.user_dast_scans",
"usage_activity_by_stage_monthly.secure.user_dependency_scanning_scans",
"usage_activity_by_stage_monthly.secure.user_sast_scans",
"usage_activity_by_stage_monthly.secure.user_secret_detection_scans"]
Metrics grouped by type:
Manage stage
Metrics
usage_activity_by_stage_monthly.manage.bulk_imports.gitlab
usage_activity_by_stage_monthly.manage.groups_imported
usage_activity_by_stage_monthly.manage.issues_imported.csv
usage_activity_by_stage_monthly.manage.issues_imported.fogbugz
usage_activity_by_stage_monthly.manage.issues_imported.jira
usage_activity_by_stage_monthly.manage.issues_imported.phabricator
usage_activity_by_stage_monthly.manage.projects_imported.bitbucket_server
usage_activity_by_stage_monthly.manage.projects_imported.bitbucket
usage_activity_by_stage_monthly.manage.projects_imported.git
usage_activity_by_stage_monthly.manage.projects_imported.gitea
usage_activity_by_stage_monthly.manage.projects_imported.github
usage_activity_by_stage_monthly.manage.projects_imported.gitlab_project
usage_activity_by_stage_monthly.manage.projects_imported.gitlab
usage_activity_by_stage_monthly.manage.projects_imported.manifest
usage_activity_by_stage_monthly.manage.projects_imported.total
usage_activity_by_stage.manage.bulk_imports.gitlab
usage_activity_by_stage.manage.groups_imported
usage_activity_by_stage.manage.issues_imported.csv
usage_activity_by_stage.manage.issues_imported.fogbugz
usage_activity_by_stage.manage.issues_imported.jira
usage_activity_by_stage.manage.issues_imported.phabricator
usage_activity_by_stage.manage.projects_imported.bitbucket_server
usage_activity_by_stage.manage.projects_imported.bitbucket
usage_activity_by_stage.manage.projects_imported.git
usage_activity_by_stage.manage.projects_imported.gitea
usage_activity_by_stage.manage.projects_imported.github
usage_activity_by_stage.manage.projects_imported.gitlab_project
usage_activity_by_stage.manage.projects_imported.gitlab
usage_activity_by_stage.manage.projects_imported.manifest
usage_activity_by_stage.manage.projects_imported.total
Manage secure
Metrics
"usage_activity_by_stage_monthly.secure.user_api_fuzzing_scans",
"usage_activity_by_stage_monthly.secure.user_cluster_image_scanning_scans",
"usage_activity_by_stage_monthly.secure.user_container_scanning_scans",
"usage_activity_by_stage_monthly.secure.user_coverage_fuzzing_scans",
"usage_activity_by_stage_monthly.secure.user_dast_scans",
"usage_activity_by_stage_monthly.secure.user_dependency_scanning_scans",
"usage_activity_by_stage_monthly.secure.user_sast_scans",
"usage_activity_by_stage_monthly.secure.user_secret_detection_scans"
"usage_activity_by_stage.secure.user_api_fuzzing_scans",
"usage_activity_by_stage.secure.user_cluster_image_scanning_scans",
"usage_activity_by_stage.secure.user_container_scanning_scans",
"usage_activity_by_stage.secure.user_coverage_fuzzing_scans",
"usage_activity_by_stage.secure.user_dast_scans",
"usage_activity_by_stage.secure.user_dependency_scanning_scans",
"usage_activity_by_stage.secure.user_sast_scans",
"usage_activity_by_stage.secure.user_secret_detection_scans",
Manage monitor
[Analytics], MR
Metrics
"usage_activity_by_stage_monthly.monitor.projects_incident_sla_enabled",
User packages
[Analytics], MR
Metrics
"redis_hll_counters.user_packages.i_package_container_user_monthly",
"redis_hll_counters.user_packages.i_package_container_user_weekly",
"redis_hll_counters.user_packages.i_package_debian_user_monthly",
"redis_hll_counters.user_packages.i_package_debian_user_weekly",
"redis_hll_counters.user_packages.i_package_golang_user_monthly",
"redis_hll_counters.user_packages.i_package_golang_user_weekly",
"redis_hll_counters.user_packages.i_package_tag_user_monthly",
"redis_hll_counters.user_packages.i_package_tag_user_weekly"
Token package
[Analytics], MR, composer_deploy_token_weekly
MR
Metrics
"redis_hll_counters.deploy_token_packages.i_package_composer_deploy_token_weekly",
"redis_hll_counters.deploy_token_packages.i_package_container_deploy_token_monthly",
"redis_hll_counters.deploy_token_packages.i_package_container_deploy_token_weekly",
"redis_hll_counters.deploy_token_packages.i_package_debian_deploy_token_monthly",
"redis_hll_counters.deploy_token_packages.i_package_debian_deploy_token_weekly",
"redis_hll_counters.deploy_token_packages.i_package_golang_deploy_token_monthly",
"redis_hll_counters.deploy_token_packages.i_package_golang_deploy_token_weekly",
"redis_hll_counters.deploy_token_packages.i_package_tag_deploy_token_monthly",
"redis_hll_counters.deploy_token_packages.i_package_tag_deploy_token_weekly"
Event package
[Analytics], MR
Metrics
"counts.package_events_i_package_container_delete_package",
"counts.package_events_i_package_container_pull_package",
"counts.package_events_i_package_container_push_package",
"counts.package_events_i_package_debian_push_package",
"counts.package_events_i_package_tag_delete_package",
"counts.package_events_i_package_tag_pull_package",
"counts.package_events_i_package_tag_push_package"
Edited by Niko Belokolodov