FE: Adjustments to the drawer for Scan Execution policies to align it with the designs for Scan Results policies
Summary
The designs for the Scan Execution policy drawer do not match the designs for the Scan Results policy drawer. The overall styles should be similar even if some
Design
- Design issue: #339368 (closed)
- Figma: https://www.figma.com/file/rHSC5J4RmwYivZLwakENCX/Policy-List?node-id=1129%3A18342
Implementation
-
frontend update base_policy_drawer component to create the base structure for the drawer that can be reused for multiple policy types -
frontend update scan_execution_drawer and network_policy_drawer to use the updated base_policy_drawer component -
frontend create a human-readable summary of scan execution policies by updating ee/app/assets/javascripts/threat_monitoring/components/policy_editor/scan_execution_policy/lib/from_yaml.js
to output asummary
property that can be used in the drawer, perhaps use some logic from https://gitlab.com/gitlab-org/protect/demos/policy-mock/-/blob/master/public/scanning-policy.js#L41 -
frontend update Policy Summary
section to match designs -
frontend updateonly for scan result policies, which are not in scope for this workPolicy Type
section to display badge for what policies are in it (i.e. dast, container scanning, etcetera) -
frontend update Status
section to match designs -
frontend addmoved to Add `pending` information to the `Status` field... (#352773)pending
badge and information toStatus
section -
frontend updatemoved to #352794Change History
section to match designs -
frontend updatemoved to #352795Latest Scan
section to match designs
This page may contain information related to upcoming products, features and functionality. It is important to note that the information presented is for informational purposes only, so please do not rely on the information for purchasing or planning purposes. Just like with all projects, the items mentioned on the page are subject to change or delay, and the development, release, and timing of any products, features, or functionality remain at the sole discretion of GitLab Inc.
Edited by Alexander Turinske