Skip to content

[Feature flag] member_destroy_async_auth_refresh

Summary

This issue is to rollout the feature on production, that is currently behind the member_destroy_async_auth_refresh feature flag.

Introduced with MR: !66424 (merged)

Owners

  • Team: Manage::Access
  • Most appropriate slack channel to reach out to: #g_manage_access
  • Best individual to reach out to: Chad Woolley
  • PM: Hannah Sutor

Stakeholders

The Rollout Plan

  • Partial Rollout on GitLab.com with testing groups
  • Rollout on GitLab.com for a certain period (How long)
  • Percentage Rollout on GitLab.com
  • Rollout Feature for everyone as soon as it's ready

Testing Groups/Projects/Users

  • gitlab-org/gitlab project
  • gitlab-org/gitlab-foss project
  • gitlab-com/www-gitlab-com project
  • gitlab-org/gitlab-com groups
  • ...

Expectations

What are we expecting to happen?

What might happen if this goes wrong?

What can we monitor to detect problems with this?

Rollout Steps

Rollout on non-production environments

  • Ensure that the feature MRs have been deployed to non-production environments.
    • /chatops run auto_deploy status 4bcd5c6e320627d14cd22700ca2e5b96714a5182
  • Enable the feature globally on non-production environments.
    • /chatops run feature set member_destroy_async_auth_refresh true --dev
    • /chatops run feature set member_destroy_async_auth_refresh true --staging
  • Verify that the feature works as expected. Posting the QA result in this issue is preferable.

QA Result

I have verified that group member deletion via API still works in staging, using the following API call:

curl -v --request DELETE --header "PRIVATE-TOKEN: $API_TOKEN" "$HOST/api/v4/groups/testcaw1/members/1808530" | jq

Preparation before production rollout

  • Ensure that the feature MRs have been deployed to both production and canary.
    • /chatops run auto_deploy status 4bcd5c6e320627d14cd22700ca2e5b96714a5182
  • Check if the feature flag change needs to be accompanied with a change management issue. Cross link the issue here if it does.
  • Ensure that you or a representative in development can be available for at least 2 hours after feature flag updates in production. If a different developer will be covering, or an exception is needed, please inform the oncall SRE by using the @sre-oncall Slack alias.
  • [-] (N/A) Ensure that documentation has been updated (More info).
  • Announce on the feature issue an estimated time this will be enabled on GitLab.com.
  • If the feature might impact the user experience, notify #support_gitlab-com and your team channel (more guidance when this is necessary in the dev docs).

Global rollout on production

All /chatops commands that target production should be done in the #production slack channel for visibility.

  • Confirm the feature flag is enabled on staging without incident
  • Incrementally roll out the feature.
    • If the feature flag in code does NOT have an actor, perform time-based rollout (random rollout).
      • /chatops run feature set member_destroy_async_auth_refresh <rollout-percentage>
  • Verify the change has the desired outcome with the limited rollout before enabling the feature globally on production.
  • Enable the feature globally on production environment. /chatops run feature set member_destroy_async_auth_refresh true
  • Announce on the feature issue that the feature has been globally enabled.
  • Wait for at least one day for the verification term.

Release the feature

After the feature has been deemed stable, the clean up should be done as soon as possible to permanently enable the feature and reduce complexity in the codebase.

  • Create a merge request to remove member_destroy_async_auth_refresh feature flag. Ask for review and merge it.
    • Remove all references to the feature flag from the codebase.
    • Remove the YAML definitions for the feature from the repository.
    • Create a changelog entry.
  • Ensure that the cleanup MR has been deployed to both production and canary. If the merge request was deployed before the code cutoff, the feature can be officially announced in a release blog post.
    • /chatops run auto_deploy status 21388c5b44aec30d94cd999ce41b22917715a77c
  • Close the feature issue to indicate the feature will be released in the current milestone.
  • Clean up the feature flag from all environments by running these chatops command in #production channel:
    • /chatops run feature delete member_destroy_async_auth_refresh --dev
    • /chatops run feature delete member_destroy_async_auth_refresh --staging
    • /chatops run feature delete member_destroy_async_auth_refresh
  • Close this rollout issue.

Rollback Steps

  • [-] This feature can be disabled by running the following Chatops command:
/chatops run feature set member_destroy_async_auth_refresh false
Edited by Chad Woolley