Follow-up of "Expose issue contacts via GraphQL"
While reviewing !71889 (merged) we've stumbled upon some implementation details for customer relationship contact.
Here's a brain dump:
-
Move spec from request API spec to issues type spec - !71889 (comment 701278756) -
Rename Group#organization
to be less ambiguous - !71889 (bad2d47d) -
Use plain has_many :customer_relationship_organization
- !71889 (bad2d47d) -
Rename Group#contacts to be less ambiguous - !... (#367882) -
Use plain has_many :customer_relationship_contacts
- !71889 (bad2d47d) -
Rename factory :contact
to be less ambiguous - !71889 (bad2d47d) -
Use plain belongs_to :group
to let Rails automatically inferinverse_of
option - !71889 (bad2d47d)- Useful to prevent n+1 queries in scenarios like
Group.find(26).contacts.map(&:group)
- Useful to prevent n+1 queries in scenarios like
-
Keep being awesome ❤
Edited by Lee Tickett