Project namespace members - update REST API
Problem
Currently, we use polymorphic association to load project members in the api endpoints:
endpoints |
---|
/projects/:id/members/:user_id |
/projects/:id/members/all |
/projects/:id/members/all/:user_id |
/projects/:id/members |
Proposal
Use new direct association through ProjectNamespace
and member_namespace_id
to load project members in this endpoints.
Consider feature flagging this change.
Availability and Testing
- No new E2E tests or updates needed at this time. Since changes will be behind a feature flag, if the MR(s) for these changes updates a feature flag definition file, please review the
ee:instance-parallel
andee:instance-parallel-ff-inverse
jobs withine2e:package-and-test
, which should be triggered automatically. - Otherwise, if these changes will be using an existing feature flag, please create a draft MR that includes these changes along with the feature flag definition file set to
default_enabled: true
. This will then trigger the jobs above to E2E test the changes with the FF both on and off (see https://docs.gitlab.com/ee/development/testing_guide/end_to_end/feature_flags.html#automatic-test-execution-when-a-feature-flag-definition-changes for more details) - Feel free to ping
@vburton
if there are any questions on E2E test failures.
Edited by Valerie Burton