Skip to content

Add missing markdown examples to Markdown Golden Master spec YAML config

UPDATE: This issue should be considered part of the larger effort in Tracking Issue: Migrate existing specs Golden M... (#361242 - closed)

The following discussion from !68671 (merged) should be addressed (see discussion thread):

how is this reconciled with our use of https://gitlab.com/gitlab-org/gitlab/blob/master/spec/fixtures/markdown.md.erb? Is everything in there covered in the new yaml file? Is one generated from the other?

@digitalmoksha I wasn't aware of that, so this Golden Master MR doesn't contain all of those examples. It's currently focused on just replacing the existing Content Editor frontend-fixtures based approach.

However, it's a great idea, and it definitely should have examples added for all markdown elements which the backend currently supports. And, with the pending attribute support, it's easy to add examples to test the backend even if the frontend doesn't support them yet.

Let's make a followup MR to add these to the config file, and discuss whether we should automate some sort of synchronization.

Tasks:

Edited by Chad Woolley