Sidekiq metrics/health-checks split 15.0 check list
Placeholder for items we need to do or think about as part of the breaking changes we introduce via #347509 (closed)
-
Update docs introduced in !76932 (merged) to demand different ports for health-checks and metrics, in case they are used/enabled -
Remove check that prevents server process from spawning when metrics and health-check ports match: https://gitlab.com/gitlab-org/gitlab/blob/f50f508bface7554f2e591fbbe64ac518ea170d5/sidekiq_cluster/cli.rb#L213 (this is the breaking change) -
Do not launch SidekiqExporter
in-worker in https://gitlab.com/gitlab-org/gitlab/blob/6760395e1a912b23d04ce9b47665a209f6ebcff4/config/initializers/7_prometheus_metrics.rb#L44; this should start some kind ofHealthCheckServer
then (via #345804 (closed)) -
Remove external cleanup logic in https://gitlab.com/gitlab-org/omnibus-gitlab/blob/02a2435eb46a0c2a5bd0877c7a3b95f005de967d/files/gitlab-cookbooks/gitlab/templates/default/sv-sidekiq-run.erb#L6, since once we know metrics will always be served via the external process, we should rely on it to do that for us (via omnibus-gitlab#6481 (closed)); Decided not to do. -
Revert logic in Omnibus and Charts (added in omnibus-gitlab!5743 (merged) and gitlab-org/charts/gitlab!2272 (merged)) that defaults health-checks to the metrics server settings. This will not work anymore. We will need to set new defaults instead (separate ports.) -
Remove Omnibus/helm chart logic that checks whether the Sidekiq exporter/health check have the same port and warns the user (Introduced in #350147 (closed), removal issue: #350148 (moved))
Edited by Matthias Käppler