Backfill SSL verification for existing CI integrations with known-good hostnames
Summary
Write a data migration to enable SSL verification on existing records for certain integrations with known-good hostnames:
-
Integrations::DroneCi
:cloud.drone.io
-
Integrations::Teamcity
:\A[^\.]+\.teamcity\.com\z
We already implemented this migration in https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/2043/diffs?commit_id=33596b7abbf1ae3545ba62690b1cc2a68f9189d3 for a security fix, but ended up handling this in the application since we're now discouraging migrations in security fixes (#349151, gitlab-org/release/docs!417 (merged)).
In the release after this migration is added, we can also remove the application code again in the Integrations::DroneCi
and Integrations::Teamcity
models.
Availability & Testing
-
Unit tests for the associated MR already exist(already implemented)💯 - There are existing tests around the migration
Edited by Markus Koller