Skip to content

Frontend: Browser popup appears when updating CI yml content and submit a merge request together with pipeline editor

Summary

While trying to edit a project's CI yml file using Pipeline Editor tool, I wanted to try out this change in a new branch first so I selected option Start a new merge request with these changes.

start_mr

However, when I click Commit changes, the editor shows unsaved changes popup instead of redirect me to create new merge request page.

Screen_Shot_2022-01-13_at_3.23.50_PM

Although this action did submit the change and push the new branch to the repo, I wasn't aware of this because of the popup alert as well as I wasn't able to create a merge request as expected.

Steps to reproduce

  1. In your project with an existing CI yml file, navigate to pipeline editor page (on left navbar CI/CD -> Editor)
  2. Attempt change the content of the CI yml file.
  3. Change target branch name to a new branch.
  4. Select start a new merge request check box below the target branch field.
  5. Click Commit changes button.

What is the current bug behavior?

An alert popup on the page that prevents redirection to create new merge request page.

What is the expected correct behavior?

  1. No alert popup
  2. The new branch is pushed to the repo
  3. The changes is committed to the new branch
  4. User is redirected to create new merge request page with the new branch

Output of checks

Can test against your GDK or on gitlab.com

Edited by Mark Nuzzo