Exception on viewing credentials inventory for instances with at least one group access token
Summary
500 exception is thrown on viewing credentials inventory for instances that have one or more group access tokens.
Steps to reproduce
- Create a group.
- Create group access token as per steps mentioned in the documentation.
- Navigate to credentials inventory.
Example Project
What is the current bug behavior?
500 exception is encountered with the following stacktrace
Sentry exception - https://sentry.gitlab.net/gitlab/staginggitlabcom/issues/3203550
Stacktrace
↳ ee/app/views/shared/credentials_inventory/personal_access_tokens/_personal_access_token.html.haml:32
Rendered collection of ee/app/views/shared/credentials_inventory/personal_access_tokens/_personal_access_token.html.haml [9 times] (Duration: 35.5ms | Allocations: 11404)
Rendered ee/app/views/shared/credentials_inventory/_personal_access_tokens.html.haml (Duration: 41.2ms | Allocations: 14992)
Rendered ee/app/views/shared/credentials_inventory/index.html.haml within layouts/admin (Duration: 49.7ms | Allocations: 23932)
Rendered layout layouts/admin.html.haml (Duration: 49.9ms | Allocations: 23991)
Completed 500 Internal Server Error in 81ms (ActiveRecord: 5.2ms | Elasticsearch: 0.0ms | Allocations: 42562)
NoMethodError - undefined method `id' for nil:NilClass:
ee/app/views/shared/credentials_inventory/personal_access_tokens/_personal_access_token.html.haml:33
ee/app/views/shared/credentials_inventory/_personal_access_tokens.html.haml:9
ee/app/views/shared/credentials_inventory/index.html.haml:21
app/controllers/application_controller.rb:142:in `render'
ee/app/controllers/concerns/credentials_inventory_actions.rb:12:in `block (2 levels) in index'
ee/app/controllers/concerns/credentials_inventory_actions.rb:10:in `index'
ee/lib/gitlab/ip_address_state.rb:10:in `with'
ee/app/controllers/ee/application_controller.rb:45:in `set_current_ip_address'
app/controllers/application_controller.rb:499:in `set_current_admin'
lib/gitlab/session.rb:11:in `with_session'
app/controllers/application_controller.rb:490:in `set_session_storage'
lib/gitlab/i18n.rb:105:in `with_locale'
lib/gitlab/i18n.rb:111:in `with_user_locale'
app/controllers/application_controller.rb:484:in `set_locale'
app/controllers/application_controller.rb:478:in `set_current_context'
lib/gitlab/metrics/elasticsearch_rack_middleware.rb:16:in `call'
lib/gitlab/middleware/rails_queue_duration.rb:33:in `call'
lib/gitlab/middleware/memory_report.rb:13:in `call'
lib/gitlab/middleware/speedscope.rb:13:in `call'
lib/gitlab/request_profiler/middleware.rb:17:in `call'
lib/gitlab/query_limiting/middleware.rb:17:in `block in call'
lib/gitlab/query_limiting/transaction.rb:40:in `run'
lib/gitlab/query_limiting/middleware.rb:16:in `call'
lib/gitlab/metrics/rack_middleware.rb:16:in `block in call'
lib/gitlab/metrics/web_transaction.rb:46:in `run'
lib/gitlab/metrics/rack_middleware.rb:16:in `call'
lib/gitlab/jira/middleware.rb:19:in `call'
lib/gitlab/middleware/go.rb:20:in `call'
lib/gitlab/etag_caching/middleware.rb:21:in `call'
lib/gitlab/middleware/query_analyzer.rb:11:in `block in call'
lib/gitlab/database/query_analyzer.rb:42:in `within'
lib/gitlab/middleware/query_analyzer.rb:11:in `call'
lib/gitlab/middleware/multipart.rb:173:in `call'
lib/gitlab/middleware/read_only/controller.rb:50:in `call'
lib/gitlab/middleware/read_only.rb:18:in `call'
lib/gitlab/middleware/same_site_cookies.rb:27:in `call'
lib/gitlab/middleware/handle_malformed_strings.rb:21:in `call'
lib/gitlab/middleware/basic_health_check.rb:25:in `call'
lib/gitlab/middleware/handle_ip_spoof_attack_error.rb:25:in `call'
lib/gitlab/middleware/request_context.rb:21:in `call'
lib/gitlab/middleware/webhook_recursion_detection.rb:15:in `call'
config/initializers/fix_local_cache_middleware.rb:11:in `call'
lib/gitlab/middleware/compressed_json.rb:26:in `call'
lib/gitlab/middleware/static.rb:11:in `call'
lib/gitlab/webpack/dev_server_middleware.rb:34:in `perform_request'
lib/gitlab/middleware/rack_multipart_tempfile_factory.rb:19:in `call'
lib/gitlab/middleware/sidekiq_web_static.rb:20:in `call'
lib/gitlab/metrics/requests_rack_middleware.rb:77:in `call'
lib/gitlab/middleware/release_env.rb:13:in `call'
What is the expected correct behavior?
Credentials inventory should load successfully.
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
Edited by Huzaifa Iftikhar