Follow-up from "Resolve "Support multiple databases for batched background migrations""
The following discussion from !80375 (merged) should be addressed:
-
@dbalexandre started a discussion: (+4 comments) We need to be aware that Geo uses the
database.yml
to configure its own database, butGitlab::Database.database_base_models[:geo]
returnsnil
. What about including Geo support here?❯ rake -T gitlab:background_migrations:finalize rake gitlab:background_migrations:finalize[job_class_name,table_name,column_name,job_arguments] # Synchronously finish executing a batched background migration rake gitlab:background_migrations:finalize:geo[job_class_name,table_name,column_name,job_arguments] # Gitlab | DB | Synchronously finish executing a batched background migration on g... rake gitlab:background_migrations:finalize:main[job_class_name,table_name,column_name,job_arguments] # Gitlab | DB | Synchronously finish executing a batched background migration on m...
We should check that rake tasks using ActiveRecord::Tasks::DatabaseTasks.setup_initial_database_yaml
work correctly with Geo, since Gitlab::Database.database_base_models
does not include the Geo base model.
Edited by Patrick Bair