The `database_async_index_creation` does not work for multiple databases
The !66478 (merged) introduced a database_async_index_creation
that is checked
as part of MigrationHelpers
:
- Since the feature flags are fetched from database it is impossible to read the state of this feature flag when running decomposed GitLab
- This is forbidden since the
FeatureFlipper
is based onActiveRecord::Base
- Running migrations for another database reconnects
ActiveRecord::Base
to suit the current migration context - This breaks feature flag fetching
This is visible as part of !73756 (merged) which validates if DDL or DML changes are correctly used.
Requirement
-
Determine if async index creation still needs to be configurable -
If so, change it to use Gitlab::Utils.to_boolean(ENV[''])
or the gitlab.rb configuration
-
-
The database_async_index_creation
feature flag is removed
Related:
Edited by Alex Ives