[Feature flag] Cleanup show_report_validation_warnings

Summary

This issue is to cleanup the show_report_validation_warnings feature flag, after the feature flag has been enabled by default for an appropriate amount of time in production.

Owners

• Team: Secure – Threat Insights
• Most appropriate slack channel to reach out to: #g_secure_threat_insights
• Best individual to reach out to: Michał Zając (DRI) (@Quintasan) or @gitlab-org/secure/threat-insights-backend-team
• PM: @matt_wilson

Stakeholders

Expectations

What might happen if this goes wrong?

1. Reports that do not pass schema validation will show up in the database
2. Some Threat Insights features might not work correctly when invalid reports get ingested
3. Users will see warnings in their pipelines Security tab

Cleaning up the feature flag

• Create a merge request to remove show_report_validation_warnings feature flag. Ask for review and merge it.
  • Remove all references to the feature flag from the codebase.
  • Remove the YAML definitions for the feature from the repository.
  • Create a changelog entry.
• Ensure that the cleanup MR has been deployed to both production and canary. If the merge request was deployed before the code cutoff, the feature can be officially announced in a release blog post.
  • /chatops run auto_deploy status <merge-commit-of-cleanup-mr>
• Close the feature issue to indicate the feature will be released in the current milestone.
• Clean up the feature flag from all environments by running these chatops command in #production channel:
  • /chatops run feature delete show_report_validation_warnings --dev
  • /chatops run feature delete show_report_validation_warnings --staging
  • /chatops run feature delete show_report_validation_warnings
• Close this rollout issue.