Skip to content

Increase gitlab-shell review-app CPU and timeout

gitlab-shell is still using close to limit 345m CPU.

Screenshot_2019-11-07_at_11.56.22_AM

Screenshot_2019-11-07_at_11.56.12_AM

The healthcheck script seems to take a very long time to complete, more than the timeout of 3 seconds

$ kubectl top node gke-review-apps-ee-n1-8cpu-16gb-preem-21d5bee0-d5h8
NAME                                                  CPU(cores)   CPU%   MEMORY(bytes)   MEMORY%
gke-review-apps-ee-n1-8cpu-16gb-preem-21d5bee0-d5h8   7268m        91%    3677Mi          27%

$ kubectl exec -it review-33604-task-5mtdl1-gitlab-shell-8494c95c9-dwfsn  /bin/bash

git@review-33604-task-5mtdl1-gitlab-shell-8494c95c9-dwfsn:/$ time /scripts/healthcheck
13

real    0m18.014s
user    0m3.303s
sys     0m0.043s

Suggestion:

  • Increase gitlab-shell cpu request and limit to 500m and 750m respectively
  • Increase readinessProbe and livenessProbe timeouts to 5 seconds