Terms cannot be deleted, once set
- Goto
<your-instance>/admin/application_settings/general#js-terms-settings
- Insert some terms
- Enable the terms
- Disable the terms again
- Try to delete the text in the TextBox
- Hit
save changes
- Notice that the text is still there
Same happens with the GitLab application settings API
Proposal
- Allow deletion of the terms if un-enabled.
- Require presences of the terms if enabled. If a user submits empty terms when enabled, the validation error message should be: "You must define the terms."
Edited by Dan Jensen