Follow-up from "Align note actions to Pajamas icon button styles"
The following discussions from !85245 (merged) should be addressed:
-
@pgascouvaillancourt started a discussion: thought: It looks like the only remaining occurrence of the
.link-highlight
class in production code is suggestion_diff_header.vue where it is passed as to aGlIcon
as thecss-classes
prop, which I don't thinkGlIcon
even supports🤔 Lets create a follow-up issue to confirm that the class isn't used and remove the associated styles. -
@pgascouvaillancourt started a discussion: thought: I don't know much about the emoji picker, but I wonder when the third icon ever shows up. We switch between the two first icons depending on the hover state, but the third one depends on the
.is-active
class being set on the button, which would look like this:But I don't remember ever seeing this while using the product
🤔 Perhaps this warrants another follow-up to make sure this variant is actually needed.edit: Oh, so this third variant is shown in HAML-based pickers, like in issues/MRs awards:
But I don't think it works with the Vue picker, perhaps we should look into it.