Clean redundant code at SubmitService
Summary
ServicePing::SubmitService
was used to both collect ServicePing payload and sent it to VersionApp (collector endpoint). With !85503 (diffs) collection logic was copied from SubmitService
, however it original bits remained in place as sort of a fallback mechanism for self managed. Goal of this issue is to clean redundant code from SubmitService
Improvements
- Removal of redundant code
- Reduced maintenance effort
- Better responsibilities separation
Risks
ServicePing reporting may break.
Involved components
Optional: Intended side effects
Optional: Missing test coverage
Testing
Ensure related tests are passing.
Edited by Carlo Catimbang