Replace `button` with `gl-button`
Summary
Previously we encountered a UI bug because the .btn-link
was removed from the code base. Below is the details for the original issue. This issue after !88967 (merged) has been merged, has been converted to migrate the button
element to the gl-button
component. See the Implementation Plan for more details.
Original Summary
Original title: Border around vulnerabilities in the Security Reports MR Widget
I'm seeing a border in the Security scanning items.
Steps to reproduce
- Visit an MR with the security scanning (e.g. !88393 (merged))
- Click
Expand
on the Security Report - See the border around the vulnerabilities
Example Project
What is the current bug behavior?
There is a border around the link
What is the expected correct behavior?
There shouldn't be a border around the link
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Implementation plan
-
frontend Replace the button
element with agl-button
here: https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/assets/javascripts/reports/components/modal_open_name.vue
Make sure the MR Security Widget and License Compliance still works as expected.