Skip to content

Migrate `form_errors` in app/views/profiles/passwords/new.html.haml to Pajamas::AlertComponent

Note: this issue is blocked until !89698 (merged) has been merged.

app/views/profiles/passwords/new.html.haml contains a reference to the form_errors helper.

As a part of &5550 (closed), we are updating all of our rails forms to replace the old error banner styling with an alert banner conforming to the Pajamas design system.

The migration process is simple:

  • Open app/views/profiles/passwords/new.html.haml
  • In your local dev environment, identify where this is rendered and find a way to force an error response. Usually you can accomplish this by submitting the form with missing or invalid inputs.
  • Take a "before" screenshot of this error response for reference
  • Add pajamas_alert: true to the method call (e.g. form_errors(@application_setting, pajamas_alert: true)) and save.
  • Force an error response again and inspect the new output for any visual regressions, missing functionality, or other concerns. Note any problems in this issue.
  • Take another screenshot for comparison
  • If all is well, publish the changes as a branch and ensure tests are passing
  • Create a MR and include both before and after screenshots in the description for ease of review
  • Identify and fix broken tests (if any)

Most likely there will be no issues or broken tests and you'll end up with a very simple, easily reviewed MR with a single-line change.

Feel free to assign yourself to multiple logically related form_errors migration issues and migrate them in a single MR.

Reference the epic description for more details and an up-to-date migration guide.