Follow-up from "Fix artifact downloads on Security tab"
The following discussion from !89217 (merged) should be addressed:
-
@jiaan started a discussion: Suggestion (non-blocking / follow-up): This took me a while to understand.
😅 WDYT about making this condition more declarative through variable names? For example creating a computed prop to describethis.findArtifacts(SECURITY_REPORT_TYPE_ENUM_DAST).length > 0)
and then referencing it here. I think it would help make this more maintainable.
How to set up and validate locally
-
Import the following gitlab project 2022-06-03_05-04-949_gitlab-examples_security_secur_export.tar.gz
-
Run the pipeline on master, wait for it to complete
-
Navigate to the pipeline page
-
Click on a single pipeline
-
Then click on the Security tab
-
Verify you can download each artifact
-
Verify artifact contents correspond to the report type