Add scan type enum to GraphQL API
Why are we doing this work
We need to add an enum that frontend can populate a dropdown with. The enum contains members for supported scan types in scan execution policies.
Implementation Plan
-
backend From Maciej's comment:
module Types
module SecurityOrchestration
class ScanTypeEnum < BaseEnum
graphql_name 'SecurityOrchestrationScanTypeEnum'
value 'SECRET_DETECTION', value: :secret_detection, description: 'Secret detection scan type.'
# TODO deprecate in 16.0 with https://gitlab.com/gitlab-org/gitlab/-/issues/373423
value 'CLUSTER_IMAGE_SCANNING', value: :cluster_image_scanning, description: 'Cluster image scanning scan type.'
value 'CONTAINER_SCANNING', value: :container_scanning, description: 'Container scanning scan type.'
value 'SAST', value: :sast, description: 'SAST scan type.'
value 'DAST', value: :dast, description: 'DAST scan type.'
end
end
end
diff --git a/ee/app/assets/javascripts/security_orchestration/components/policy_editor/scan_execution_policy/constants.js b/ee/app/assets/javascripts/security_orchestration/components/policy_editor/scan_execution_policy/constants.js
index 383168237b3f..3c39e87c1a66 100644
--- a/ee/app/assets/javascripts/security_orchestration/components/policy_editor/scan_execution_policy/constants.js
+++ b/ee/app/assets/javascripts/security_orchestration/components/policy_editor/scan_execution_policy/constants.js
@@ -35,12 +35,3 @@ export const SCANNER_HUMANIZED_TEMPLATE = s__(
export const DAST_HUMANIZED_TEMPLATE = s__(
'ScanExecutionPolicy|%{thenLabelStart}Then%{thenLabelEnd} Require a %{scan} scan to run with site profile %{siteProfile} and scanner profile %{scannerProfile}',
);
-
-// TODO remove after https://gitlab.com/gitlab-org/gitlab/-/issues/365579
-export const TEMPORARY_LIST_OF_SCANNERS = {
- sast: SAST_SHORT_NAME,
- dast: DAST_SHORT_NAME,
- secret_detection: SECRET_DETECTION_NAME,
- container_scanning: CONTAINER_SCANNING_NAME,
- cluster_image_scanning: CLUSTER_IMAGE_SCANNING_NAME,
-};
Edited by Alexander Turinske