[Verify] Security MR Widget no longer calls vulnerability_feedback endpoint
Description
This issue requires no code changes; once &8353 (closed) is complete, we just need to verify that the vulnerability_feedback
endpoint is no longer being called.
On the MR details page, there's a MR security widget:
For each report type in the widget, a request is made to http://${group}/${project}/-/merge_requests/${id}/${report_type}_reports
:
An additional call is also made to ``http://{group}/
{project}/-/merge_requests/{id}/vulnerability_feedback?category=
{report_type}`:
However, this request is very expensive because rather than returning only the feedback objects for the vulnerabilities returned by the previous request, it will return all feedback objects in the project. On the live server, this can be thousands of feedback objects, which is causing performance issues.
!92339 (merged) added the ability to page the vulnerability_feedback
endpoint, but we would still need to download every single page, so it doesn't really solve the performance issue, it just breaks up one request into multiple smaller ones.
Instead, the report diff endpoint already returns vulnerability data with the feedback objects embedded in them:
So we should use that data instead and remove the vulnerability_feedback
call.