RuboCop: Enable previously disabled cops
Problem
In Split up .rubocop_todo.yml into .rubocop_todo/*... (#354328 - closed) we've disabled some cops due to too many offenses to make the split easier.
Currently, there are 71
Implementation Guide
Enable all
- Pick a
👮 offense from The List below e.g.RSpec/ReturnFromStub
- Create a branch (e.g.
369268-rubocop-reneable-RSpec/ReturnFromStub
)- Info: Using this issue ID (
369268
) in a branch name will add required labels and reference to this issue in the new merge request.
- Info: Using this issue ID (
- Delete
Enabled: false
from the corresponding.rubocop_todo/
YAML file (e.g. https://gitlab.com/gitlab-org/gitlab/-/blob/211c7bdf7e171a6f7528d8b234343c591e44daaf/.rubocop_todo/rspec/return_from_stub.yml#L6) -
Re-generate the TODO list via e.g.
bundle exec rake 'rubocop:todo:generate[RSpec/ReturnFromStub]'
- Commit changed YAML file and create an MR
- Hint: You can use
RuboCop: Enable previously disabled cop <COP/NAME>
as git commit message - Info: Community contributions can use git trailer
Changelog: other
so they are attributed inCHANGELOG.md
- Hint: You can use
- Mention this merge request in this issue
🎉
The list
A list containing all previously disabled
-
Capybara/VisibilityMatcher
- !94124 (merged) -
Layout/ArgumentAlignment
- !93716 (merged) -
Layout/FirstArrayElementIndentation
- !93715 (merged) -
Layout/FirstHashElementIndentation
- !93714 (merged) -
Layout/HashAlignment
- !93713 (merged) -
Layout/MultilineOperationIndentation
- !93717 (merged) - [-]
Lint/RedundantCopDisableDirective
- !99217 (merged) -
Layout/SpaceAroundMethodCallOperator
!95022 (closed) -
Layout/SpaceInLambdaLiteral
- !93718 (merged) -
Layout/SpaceInsideBlockBraces
- !93729 (merged) -
Layout/SpaceInsideParens
- !93822 (merged) -
Lint/ConstantDefinitionInBlock
- !93820 (merged) -
Lint/MissingCopEnableDirective
- !93823 (merged) -
Naming/HeredocDelimiterNaming
- !93825 (merged) - [-]
Naming/RescuedExceptionsVariableName
- !93828 (merged) -
Rails/ActiveRecordCallbacksOrder
- !94014 (merged) -
Rails/ContentTag
- !94015 (merged) -
Rails/CreateTableWithTimestamps
- !94019 (merged) -
Rails/FilePath
- !94021 (merged) -
Rails/HasManyOrHasOneDependent
- !94024 (merged) -
Rails/HelperInstanceVariable
- !94027 (merged) -
Rails/IndexWith
- !94035 (merged) -
Rails/InverseOf
- !94037 (merged) -
Rails/LexicallyScopedActionFilter
- !94040 (merged) -
Rails/NegateInclude
- !94042 (merged) -
Rails/Pick
- !94044 (closed) -
Rails/Pluck
- !94047 (merged) -
Rails/RakeEnvironment
- !94049 (closed) -
Rails/RedundantForeignKey
- !94055 (merged) -
Rails/SkipsModelValidations
- !94061 (merged) -
Rails/SquishedSQLHeredocs
- !94064 (merged) -
Rails/WhereExists
- !94068 (merged) -
RSpec/RepeatedExampleGroupDescription
- !91497 (merged) -
Style/AccessorGrouping
- !94071 (merged) -
Style/BarePercentLiterals
- !94078 (merged) -
Style/CaseLikeIf
- !94080 (merged) -
Style/EmptyElse
- !94103 (merged) -
Style/EmptyMethod
- !94087 (merged) -
Style/ExplicitBlockArgument
- !94090 (merged) -
Style/FormatString
- !94092 (merged) -
Style/GuardClause
- !94099 (merged) -
Style/HashAsLastArrayItem
- !94112 (merged) -
Style/HashEachMethods
- !94115 (merged) -
Style/IfInsideElse
- !94117 (merged) -
Style/IfUnlessModifier
- !94119 (merged) -
Style/KeywordParametersOrder
- !94120 (merged) -
Style/Lambda
- !94317 (merged) -
Style/MissingRespondToMissing
- !94321 (merged) -
Style/Next
- !94325 (merged) -
Style/NumericLiteralPrefix
- !94327 (merged) -
Style/PercentLiteralDelimiters
- !94329 (merged) -
Style/RedundantInterpolation
- !94331 (merged) -
Style/RedundantRegexpEscape
- !94334 (merged) -
Style/RedundantSelf
- !94342 (merged) -
Style/RescueModifier
- !94344 (closed) -
Style/SingleArgumentDig
- !94351 (merged) -
Style/SoleNestedConditional
- !94352 (merged) -
Style/StringConcatenation
- !94357 (merged) -
Style/StringLiteralsInInterpolation
- !94362 (merged) -
Style/SymbolProc
- !94372 (merged) -
Performance/BlockGivenWithExplicitBlock
- !92454 (merged) -
Performance/CollectionLiteralInLoop
- !92454 (merged) -
Performance/ConstantRegexp
- !92454 (merged) -
Performance/MethodObjectAsBlock
- !92454 (merged) -
RSpec/ContextWording
- !92980 (merged) -
RSpec/ExpectChange
- !93450 (merged) -
RSpec/ExpectInHook
- !92896 (merged) -
RSpec/PredicateMatcher
- !93450 (merged) -
RSpec/RepeatedExampleGroupBody
- !91497 (merged) -
RSpec/ReturnFromStub
- !92893 (merged) -
RSpec/ScatteredLet
- !92897 (merged)
The script
# frozen_string_literal: true
require "yaml"
sha = `git rev-parse HEAD`.chomp
template = <<~MD
- [ ] [`%{rule_name}`](https://gitlab.com/gitlab-org/gitlab/-/blob/#{sha}/%{filename})
MD
Dir[".rubocop_todo/**/*.yml"].sort.each do |file|
yaml = YAML.load_file(file)
rule_name, conf = yaml.first
next unless conf["Enabled"] == false
puts format(template, rule_name: rule_name, filename: file, sha: sha)
end
Edited by Peter Leitzen