blame pagination breaks rev (branch/tag) switcher
Summary
Blame
cannot be continued on switching rev (branch/tag) after blame_page_pagination (probably !85827 (merged) and/or #360927 (closed), #225174 (closed)).
Steps to reproduce
- Visit https://gitlab.com/gitlab-org/gitlab/-/blob/a873c0f94be51659ddc3ac90ab1a00fc0b4dead9/VERSION
- Click the blame icon to move to https://gitlab.com/gitlab-org/gitlab/-/blame/39a53802a62fb48642653d7d81c5e23c4215d18c/VERSION?page=1 (with
page=1
) - Select any branch from switch branch/tag to see that the error message
"VERSION?page=1" did not exist on "some-branch-you-selected"
is shown on top and thatblame
stops.
What is the current bug behavior?
- The error message
"VERSION?page=1" did not exist on "some-branch-you-selected"
is shown on top. (suppose that you select the branchsome-branch-you-selected
) - A user is redirected to
https://gitlab.com/gitlab-org/gitlab/-/tree/some-branch-you-selected
. (suppose that you select the branchsome-branch-you-selected
)
This bug looks intrinsic and so has happened when an URLs is modified. For example, just switching the branch/tag starting from https://gitlab.com/gitlab-org/gitlab/-/blob/master/VERSION?page=1
, you can run into the same error.
What is the expected correct behavior?
https://gitlab.com/gitlab-org/gitlab/-/blob/some-branch-you-selected/VERSION
should be rendered without any error message. (suppose that you select the branch some-branch-you-selected
)
Relevant logs and/or screenshots
Output of checks
This bug happens on GitLab.com (15.3-pre).
Edited by Takuya Noguchi