Show JUnit test reports immediately on pipeline tests tab
Summary
Originally reported in #363310 (closed)
On the pipeline test reports tab, we want to immediately show all test reports that have already been generated regardless if the pipeline is incomplete.
What is the current bug behavior?
On the pipeline tests tab, the message Job artifacts are expired Test reports require job artifacts but all artifacts are expired. Learn more
will show up if the pipeline is incomplete but there are test reports present.
What is the expected correct behavior?
On the pipeline test reports tab, we want to immediately show all test reports that have already been generated regardless if the pipeline is incomplete. This is fine because we don't do any report comparison in this page. This will eventually get updated with more test reports as the pipeline progresses.
Possible fixes
- Rename
has_reports?
tocomplete_and_has_reports?
- This is on its own MR.
- This is just a plain rename of the method, no other changes to behavior. Our main goal is to extract
complete?
check out of thehas_reports?
method. So we just want to rename this one for now into a temporary method just to see which reports need such behavior or not.
- Add
has_reports
but withoutcomplete?
check- This is the 2nd MR.
- Here we add back the
has_reports?
method but now without the pipelinecomplete?
check. - In the same MR, use this for the pipeline test reports endpoint.
- I.e change Pipeline::TestsController to from pipeline.complete_and_has_reports? to pipeline.has_reports?
Edited by Erick Bajao