Broken master in spec/lib/gitlab/background_migration/rename_task_system_note_to_checklist_item_spec.rb

Job #2923735888 failed for 7e0e5f0a:

Failures:
  1) Gitlab::BackgroundMigration::RenameTaskSystemNoteToChecklistItem tracks timings of queries
     Failure/Error: expect { perform_migration }.to change { migration.batch_metrics.timings }
       expected `migration.batch_metrics.timings` to have changed, but is still {}
     # ./spec/lib/gitlab/background_migration/rename_task_system_note_to_checklist_item_spec.rb:89:in `block (2 levels) in <main>'
     # ./spec/spec_helper.rb:435:in `block (3 levels) in <top (required)>'
     # ./spec/support/sidekiq_middleware.rb:9:in `with_sidekiq_server_middleware'
     # ./spec/spec_helper.rb:426:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:422:in `block (3 levels) in <top (required)>'
     # ./lib/gitlab/application_context.rb:56:in `with_raw_context'
     # ./spec/spec_helper.rb:422:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:265:in `block (2 levels) in <top (required)>'
     # ./spec/support/system_exit_detected.rb:7:in `block (2 levels) in <main>'
     # ./spec/support/flaky_tests.rb:27:in `block (2 levels) in <main>'
     # ./spec/support/database_cleaner.rb:42:in `block (2 levels) in <main>'
     # ./spec/support/database/prevent_cross_joins.rb:106:in `block (3 levels) in <main>'
     # ./spec/support/database/prevent_cross_joins.rb:60:in `with_cross_joins_prevented'
     # ./spec/support/database/prevent_cross_joins.rb:106:in `block (2 levels) in <main>'
     # ./spec/support/database/multiple_databases.rb:118:in `block (2 levels) in <main>'
  2) Gitlab::BackgroundMigration::RenameTaskSystemNoteToChecklistItem updates in batches
     Failure/Error: expect { perform_migration }.to make_queries_matching(/UPDATE notes/, 2)
       expected (?-mix:UPDATE notes) to match 2 queries, got 0 matches:
       []
     # ./spec/lib/gitlab/background_migration/rename_task_system_note_to_checklist_item_spec.rb:83:in `block (2 levels) in <main>'
     # ./spec/spec_helper.rb:435:in `block (3 levels) in <top (required)>'
     # ./spec/support/sidekiq_middleware.rb:9:in `with_sidekiq_server_middleware'
     # ./spec/spec_helper.rb:426:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:422:in `block (3 levels) in <top (required)>'
     # ./lib/gitlab/application_context.rb:56:in `with_raw_context'
     # ./spec/spec_helper.rb:422:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:265:in `block (2 levels) in <top (required)>'
     # ./spec/support/system_exit_detected.rb:7:in `block (2 levels) in <main>'
     # ./spec/support/flaky_tests.rb:27:in `block (2 levels) in <main>'
     # ./spec/support/database_cleaner.rb:42:in `block (2 levels) in <main>'
     # ./spec/support/database/prevent_cross_joins.rb:106:in `block (3 levels) in <main>'
     # ./spec/support/database/prevent_cross_joins.rb:60:in `with_cross_joins_prevented'
     # ./spec/support/database/prevent_cross_joins.rb:106:in `block (2 levels) in <main>'
     # ./spec/support/database/multiple_databases.rb:118:in `block (2 levels) in <main>'
  3) Gitlab::BackgroundMigration::RenameTaskSystemNoteToChecklistItem renames task to checklist item in task system notes that match
     Failure/Error:
           expect do
             perform_migration
       
             note1.reload
             note2.reload
             note3.reload
             note4.reload
           end.to change(note1, :note).to('marked the checklist item **Task 1** as complete').and(
             not_change(note2, :note).from('NO_MATCH marked the task **Task 2** as complete')
           ).and(
          expected `#<Class:0x00007fe2cb7a99e0>#note` to have changed to "marked the checklist item **Task 1** as complete", but did not change
       ...and:
          expected `#<Class:0x00007fe2cb7a99e0>#note` to have changed to "marked the checklist item **Task 3** as incomplete", but did not change
     # ./spec/lib/gitlab/background_migration/rename_task_system_note_to_checklist_item_spec.rb:66:in `block (2 levels) in <main>'
     # ./spec/spec_helper.rb:435:in `block (3 levels) in <top (required)>'
     # ./spec/support/sidekiq_middleware.rb:9:in `with_sidekiq_server_middleware'
     # ./spec/spec_helper.rb:426:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:422:in `block (3 levels) in <top (required)>'
     # ./lib/gitlab/application_context.rb:56:in `with_raw_context'
     # ./spec/spec_helper.rb:422:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:265:in `block (2 levels) in <top (required)>'
     # ./spec/support/system_exit_detected.rb:7:in `block (2 levels) in <main>'
     # ./spec/support/flaky_tests.rb:27:in `block (2 levels) in <main>'
     # ./spec/support/database_cleaner.rb:42:in `block (2 levels) in <main>'
     # ./spec/support/database/prevent_cross_joins.rb:106:in `block (3 levels) in <main>'
     # ./spec/support/database/prevent_cross_joins.rb:60:in `with_cross_joins_prevented'
     # ./spec/support/database/prevent_cross_joins.rb:106:in `block (2 levels) in <main>'
     # ./spec/support/database/multiple_databases.rb:118:in `block (2 levels) in <main>'
Finished in 28.92 seconds (files took 52.02 seconds to load)
3 examples, 3 failures
Failed examples:
rspec ./spec/lib/gitlab/background_migration/rename_task_system_note_to_checklist_item_spec.rb:86 # Gitlab::BackgroundMigration::RenameTaskSystemNoteToChecklistItem tracks timings of queries
rspec ./spec/lib/gitlab/background_migration/rename_task_system_note_to_checklist_item_spec.rb:82 # Gitlab::BackgroundMigration::RenameTaskSystemNoteToChecklistItem updates in batches
rspec ./spec/lib/gitlab/background_migration/rename_task_system_note_to_checklist_item_spec.rb:65 # Gitlab::BackgroundMigration::RenameTaskSystemNoteToChecklistItem renames task to checklist item in task system notes that match

The spec was introduced by !95631 (merged) (now in production).