Starring or un-starring a project does not refresh its star count in the home page.
Steps to reproduce:
- Land on gitlab.com
- Pick the first project in the list, notice its star count, open the project's page, and star that project.
- Go back to gitlab.com and refresh the page.
- You will notice that the star count hasn't been increased by 1.
Expected output: Star count should have increased by 1 after the refresh.
Root cause:
With !95162 (diffs), we are not updating the updated_at
of the project
record anymore when it is starred.
And our page is fragment cached here, with the cache key only containing updated_at
of the project as one of its keys.
However, since we have stopped updating the updated_at
of the project on starring/un-starring, this cache doesn't bust anymore, and hence the count appears stale.
Possible solutions:
- Include
project.start_count
into the cache key's definition.
Note: Fragment caching is disabled by default in development. To reproduce this issue in development, we will have to run rails dev:cache
on the console before attempting to reproduce the issue.