Branch rules MVC: Display branch rules details
Description
Displays details of the branch rules. This is a readonly view.
Scope
- Display branch name/pattern
- Display matching branches
- Display branch protections
- Display merge request approvals
- Display status checks
- Navigate to the current settings sections to provide a way to edit.
- Details page URL will be under
/-/settings/repository/branch_rules
- Will use a query parameter to specify a particular branch rule
- Default will link to ???
- If there are no branch rules we should display an empty state (TBD)
Mockups
Form | In Page | All branches | All protected branches |
---|---|---|---|
- Changed the title from "View branch rules" to "Branch rules details"
Questions
-
question: When viewing the details page, what is the URL? #372362 (comment 1085468757) -
Answer:
<project>/-/settings/repository/branch_rules?branch=BRANCH_RULE_NAME/BRANCH_RULE_PATTERN
-
Answer:
-
question: Are we able to display the matching branches in the details view or should we link off the matching branch page? #372362 (comment 1085475210) - Answer: Linking off to matching branch page
-
question: Should this issue include the work to navigate to the respective settings section of each branch rule section? #372362 (comment 1088203462) - Answer: We can navigate to a page with expanded sections #372362 (comment 1088241391)
-
question: What might be the difference between selecting "All branches" vs "All protected branches"?
Testing
Exploratory and regression testing in MRs, please ensure all tests still pass including e2e:package-and-test
.
Edited by Anastasia McDonald