Add instrumentation classes for missing secure metrics
Instrumentation classes were added with #339447 (closed) (closed)
To be able to remove the related code from usage_data.rb
prefix = 'user_'
results = {
user_preferences_group_overview_security_dashboard: count(::User.active.group_view_security_dashboard.where(time_period))
}
results.merge!(count_secure_pipelines(time_period))
results.merge!(count_secure_scans(time_period))
results[:"#{prefix}unique_users_all_secure_scanners"] = distinct_count(::Ci::Build.where(name: SECURE_PRODUCT_TYPES.keys).where(time_period), :user_id)
# handle license rename https://gitlab.com/gitlab-org/gitlab/issues/8911
combined_license_key = "#{prefix}license_management_jobs".to_sym
license_scan_count = results.delete("#{prefix}license_scanning_jobs".to_sym)
results[combined_license_key] += license_scan_count > 0 ? license_scan_count : 0 if license_scan_count.is_a?(Integer)
super.merge(results)
we need to add missing instrumentation classes.
These are pending metrics
0> (metric_files_key_paths + events_not_defined_yet) - usage_ping_key_paths
=> ["usage_activity_by_stage.secure.api_fuzzing_scans", "usage_activity_by_stage.secure.cluster_image_scanning_scans", "usage_activity_by_stage.secure.container_scanning_scans", "usage_activity_by_stage.secure.coverage_fuzzing_scans", "usage_activity_by_stage.secure.dast_scans", "usage_activity_by_stage.secure.dependency_scanning_scans", "usage_activity_by_stage.secure.sast_scans", "usage_activity_by_stage.secure.secret_detection_scans", "usage_activity_by_stage.secure.user_preferences_group_overview_security_dashboard", "usage_activity_by_stage.secure.user_unique_users_all_secure_scanners", "usage_activity_by_stage_monthly.secure.api_fuzzing_pipeline", "usage_activity_by_stage_monthly.secure.api_fuzzing_scans", "usage_activity_by_stage_monthly.secure.cluster_image_scanning_pipeline", "usage_activity_by_stage_monthly.secure.cluster_image_scanning_scans", "usage_activity_by_stage_monthly.secure.container_scanning_pipeline", "usage_activity_by_stage_monthly.secure.container_scanning_scans", "usage_activity_by_stage_monthly.secure.coverage_fuzzing_pipeline", "usage_activity_by_stage_monthly.secure.coverage_fuzzing_scans", "usage_activity_by_stage_monthly.secure.dast_pipeline", "usage_activity_by_stage_monthly.secure.dast_scans", "usage_activity_by_stage_monthly.secure.dependency_scanning_pipeline", "usage_activity_by_stage_monthly.secure.dependency_scanning_scans", "usage_activity_by_stage_monthly.secure.sast_pipeline", "usage_activity_by_stage_monthly.secure.sast_scans", "usage_activity_by_stage_monthly.secure.secret_detection_pipeline", "usage_activity_by_stage_monthly.secure.secret_detection_scans", "usage_activity_by_stage_monthly.secure.user_preferences_group_overview_security_dashboard", "usage_activity_by_stage_monthly.secure.user_unique_users_all_secure_scanners"]
0> ((metric_files_key_paths + events_not_defined_yet) - usage_ping_key_paths).length
=> 28
Related to #358148 (closed)
Edited by Jonas Larsen